[coreboot-gerrit] Change in coreboot[master]: google/kahlee: Start Kahlee mainboard

[Marc Jones (Code Review)]

Marc Jones has posted comments on this change. ( https://review.coreboot.org/19830 )

Change subject: google/kahlee: Start Kahlee mainboard
......................................................................


Patch Set 3:

(1 comment)

https://review.coreboot.org/#/c/19830/3/src/mainboard/google/kahlee/bootblock/OemCustomize.c
File src/mainboard/google/kahlee/bootblock/OemCustomize.c:

PS3, Line 102: static const UINT32 AzaliaCodecAlc286Table[] =
             : {
             : 	0x00172051, 0x001721C7, 0x00172222, 0x00172310,
             : 	0x0017FF00, 0x0017FF00, 0x0017FF00, 0x0017FF00,
             : 	0x01271C50, 0x01271D01, 0x01271EA6, 0x01271FB7,
             : 	0x01371C00, 0x01371D00, 0x01371E00, 0x01371F40,
             : 	0x01471C10, 0x01471D01, 0x01471E17, 0x01471F90,
             : 	0x01771CF0, 0x01771D11, 0x01771E11, 0x01771F41,
             : 	0x01871C40, 0x01871D10, 0x01871EA1, 0x01871F04,
             : 	0x01971CF0, 0x01971D11, 0x01971E11, 0x01971F41,
             : 	0x01A71CF0, 0x01A71D11, 0x01A71E11, 0x01A71F41,
             : 	0x01D71C2D, 0x01D71DA5, 0x01D71E67, 0x01D71F40,
             : 	0x01E71C30, 0x01E71D11, 0x01E71E45, 0x01E71F04,
             : 	0x02171C20, 0x02171D10, 0x02171E21, 0x02171F04,
             : 	0x02050071, 0x02040014, 0x02050010, 0x02040C22,
             : 	0x0205004F, 0x0204B029, 0x0205002B, 0x02040C50,
             : 	0x0205002D, 0x02041020, 0x02050020, 0x02040000,
             : 	0x02050019, 0x02040817, 0x02050035, 0x02041AA5,
             : 	0x02050063, 0x02042906, 0x02050063, 0x02042906,
             : 	0xffffffff
             : };
> Where else would it be? 
Ah, I understand your comment as about this file. This probably needs a better split. Lets put the comment in the gardenia patch earlier in the stack.


-- 
To view, visit https://review.coreboot.org/19830
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia68b16969518f4d63d5d2dea7658a472b2daca05
Gerrit-PatchSet: 3
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer at coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-HasComments: Yes