[coreboot-gerrit] Change in coreboot[master]: purism/librem13v1: Set FADT revision to ACPI 3.0

Youness Alaoui (Code Review) gerrit at coreboot.org
Thu Jun 1 00:53:15 CEST 2017


Hello Matt DeVillier, build bot (Jenkins),

I'd like you to reexamine a change.  Please visit

    https://review.coreboot.org/19985

to look at the new patch set (#3).

Change subject: purism/librem13v1: Set FADT revision to ACPI 3.0
......................................................................

purism/librem13v1: Set FADT revision to ACPI 3.0

The FADT revision was set to 5, but we do not implement the
ACPI v5.0 specification, which prevents Windows from booting.
Setting it to v3 (matching most other boards) fixes the issue
and Windows now boots normally.

Bug found by Matt DeVillier, fix tested by Youness Alaoui on
Librem 13 v1 hardware.

Please also see commits 00d250e2289de (intel/skylake: Switch FADT
to ACPI version 3.0) [1] and 27e6042bb7d0b1 (intel/apollolake:
Switch FADT to ACPI version 3.0) [2].

[1] https://review.coreboot.org/19453
[2] https://review.coreboot.org/19146

Change-Id: Ide97cbf64f7b05018433436431ab4723b217fe22
Signed-off-by: Youness Alaoui <youness.alaoui at puri.sm>
Signed-off-by: Matt DeVillier <matt.devillier at gmail.com>
---
M src/mainboard/purism/librem13v1/fadt.c
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/19985/3
-- 
To view, visit https://review.coreboot.org/19985
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ide97cbf64f7b05018433436431ab4723b217fe22
Gerrit-PatchSet: 3
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Youness Alaoui <snifikino at gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier at gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Werner Zeh <werner.zeh at siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>



More information about the coreboot-gerrit mailing list