[coreboot-gerrit] Change in coreboot[master]: intel/sandybridge: Clean VGA BIOS ids up a little

Nico Huber (Code Review) gerrit at coreboot.org
Sat Jul 29 01:51:58 CEST 2017


Nico Huber has uploaded this change for review. ( https://review.coreboot.org/20814


Change subject: intel/sandybridge: Clean VGA BIOS ids up a little
......................................................................

intel/sandybridge: Clean VGA BIOS ids up a little

Sync map_oprom_vendev() with the list of PCI ids in the `gma.c` driver,
remove one obsolete Kconfig default override.

Change-Id: I12f24f415b695c516fbb947114e09c873af2e439
Signed-off-by: Nico Huber <nico.h at gmx.de>
---
M src/mainboard/lenovo/t530/Kconfig
M src/northbridge/intel/sandybridge/gma.c
2 files changed, 6 insertions(+), 8 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/20814/1

diff --git a/src/mainboard/lenovo/t530/Kconfig b/src/mainboard/lenovo/t530/Kconfig
index 84ebe86..065fd3c 100644
--- a/src/mainboard/lenovo/t530/Kconfig
+++ b/src/mainboard/lenovo/t530/Kconfig
@@ -52,10 +52,6 @@
 	int
 	default 10
 
-config VGA_BIOS_ID
-	string
-	default "8086,0106"
-
 config VGA_BIOS_FILE
 	string
 	default "pci8086,0106.rom"
diff --git a/src/northbridge/intel/sandybridge/gma.c b/src/northbridge/intel/sandybridge/gma.c
index 6d1044c..097df14 100644
--- a/src/northbridge/intel/sandybridge/gma.c
+++ b/src/northbridge/intel/sandybridge/gma.c
@@ -258,7 +258,7 @@
 
 u32 map_oprom_vendev(u32 vendev)
 {
-	u32 new_vendev=vendev;
+	u32 new_vendev = vendev;
 
 	switch (vendev) {
 	case 0x80860102:		/* GT1 Desktop */
@@ -267,9 +267,11 @@
 	case 0x80860116:		/* GT2 Mobile */
 	case 0x80860122:		/* GT2 Desktop >=1.3GHz */
 	case 0x80860126:		/* GT2 Mobile >=1.3GHz */
-	case 0x80860156:                /* IVB */
-	case 0x80860166:                /* IVB */
-		new_vendev=0x80860106;	/* GT1 Mobile */
+	case 0x80860152:                /* IVB Desktop */
+	case 0x80860156:                /* IVB Mobile */
+	case 0x80860162:                /* IVB Desktop */
+	case 0x80860166:                /* IVB Mobile */
+		new_vendev = 0x80860106;/* GT1 Mobile */
 		break;
 	}
 

-- 
To view, visit https://review.coreboot.org/20814
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I12f24f415b695c516fbb947114e09c873af2e439
Gerrit-Change-Number: 20814
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber <nico.h at gmx.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170728/4c116696/attachment.html>


More information about the coreboot-gerrit mailing list