[coreboot-gerrit] Change in coreboot[master]: mb/lenovo/t*00/romstage: Switch to new hybrid driver

Patrick Rudolph (Code Review) gerrit at coreboot.org
Thu Jul 27 19:35:46 CEST 2017


Hello build bot (Jenkins), 

I'd like you to reexamine a change. Please visit

    https://review.coreboot.org/20794

to look at the new patch set (#2).

Change subject: mb/lenovo/t*00/romstage: Switch to new hybrid driver
......................................................................

mb/lenovo/t*00/romstage: Switch to new hybrid driver

Get rid of old hybrid graphics driver and use the new one.

1. Disable IGD and PEG in early romstage.
 The PEG port will get disabled on devices that do not have a discrete GPU.
 The power savings are around ~1Watt.

 The disabled IGD does no longer waste GFX stolen memory.

2. The Nvidia GPU can be handled by the generic PCI driver and allows to use
 the _ROM generator for Switchable graphics.

3. Settings are stored in devicetree.
 One driver for all Lenovo hybrid graphics capable devices.

Needs test on all devices.

Change-Id: Ibf18b75e8afe2568de8498b39a608dac8db3ba73
Signed-off-by: Patrick Rudolph <siro at das-labor.org>
---
M src/drivers/lenovo/Kconfig
M src/drivers/lenovo/Makefile.inc
D src/drivers/lenovo/hybrid_graphics.c
M src/mainboard/lenovo/t420/devicetree.cb
M src/mainboard/lenovo/t420/romstage.c
M src/mainboard/lenovo/t420s/devicetree.cb
M src/mainboard/lenovo/t420s/romstage.c
M src/mainboard/lenovo/t430/devicetree.cb
M src/mainboard/lenovo/t430/romstage.c
M src/mainboard/lenovo/t520/devicetree.cb
M src/mainboard/lenovo/t520/romstage.c
M src/mainboard/lenovo/t530/devicetree.cb
M src/mainboard/lenovo/t530/romstage.c
13 files changed, 195 insertions(+), 131 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/20794/2
-- 
To view, visit https://review.coreboot.org/20794
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibf18b75e8afe2568de8498b39a608dac8db3ba73
Gerrit-Change-Number: 20794
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170727/53598c7e/attachment.html>


More information about the coreboot-gerrit mailing list