[coreboot-gerrit] Change in coreboot[master]: payloads/external/tianocore: Use consistent print statement syntax

Logan Carlson (Code Review) gerrit at coreboot.org
Wed Jul 26 22:13:09 CEST 2017


Logan Carlson has uploaded this change for review. ( https://review.coreboot.org/20783


Change subject: payloads/external/tianocore: Use consistent print statement syntax
......................................................................

payloads/external/tianocore: Use consistent print statement syntax

Change occurences of printf statements to echo statements to improve
consistency.

Change-Id: I6e2b71a5ddf117398d3f9f30981cc54c926c05a2
Signed-off-by: Logan Carlson <logancarlson at google.com>
---
M payloads/external/tianocore/Makefile
1 file changed, 7 insertions(+), 7 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/20783/1

diff --git a/payloads/external/tianocore/Makefile b/payloads/external/tianocore/Makefile
index fdca95c..f2a507c 100644
--- a/payloads/external/tianocore/Makefile
+++ b/payloads/external/tianocore/Makefile
@@ -56,19 +56,19 @@
 		echo "Applying $$patch"; \
 		cd $(project_dir); \
 		git am --keep-cr $$patch || \
-			( printf " Error when applying patches.\n"; git am --abort; exit 1; ); \
+			( echo " Error when applying patches."; git am --abort; exit 1; ); \
 	done
 
 checktools:
-	printf "Checking uuid-dev..."
+	echo "Checking uuid-dev..."
 	echo "#include <uuid/uuid.h>" > libtest.c
 	echo "int main(int argc, char **argv) { (void) argc; (void) argv; return 0; }" >> libtest.c
-	$(HOSTCC) $(HOSTCCFLAGS) libtest.c -o libtest >/dev/null 2>&1 && printf " found uuid-dev.\n" || \
-		( printf " Not found.\n"; echo "ERROR: please_install uuid-dev (uuid-devel)"; exit 1 )
+	$(HOSTCC) $(HOSTCCFLAGS) libtest.c -o libtest >/dev/null 2>&1 && echo " found uuid-dev." || \
+		( echo " Not found."; echo "ERROR: please_install uuid-dev (uuid-devel)"; exit 1 )
 	rm -rf libtest.c libtest
-	printf "Checking nasm..."
-	type nasm > /dev/null 2>&1 && printf " found nasm.\n" || \
-		( printf " Not found.\n"; echo "Error: Please install nasm."; exit 1 )
+	echo "Checking nasm..."
+	type nasm > /dev/null 2>&1 && echo " found nasm." || \
+		( echo " Not found."; echo "Error: Please install nasm."; exit 1 )
 
 config: checkout checktools
 	unset CC; $(MAKE) -C $(project_dir)/BaseTools

-- 
To view, visit https://review.coreboot.org/20783
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6e2b71a5ddf117398d3f9f30981cc54c926c05a2
Gerrit-Change-Number: 20783
Gerrit-PatchSet: 1
Gerrit-Owner: Logan Carlson <logancarlson at google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170726/a4995f30/attachment-0001.html>


More information about the coreboot-gerrit mailing list