[coreboot-gerrit] Change in coreboot[master]: util/inteltool: Add support of SGX status

Philipp Deppenwiese (Code Review) gerrit at coreboot.org
Tue Jul 25 14:51:10 CEST 2017


Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/20758 )

Change subject: util/inteltool: Add support of SGX status
......................................................................


Patch Set 1: Code-Review+2

(2 comments)

Looks good to me. Only small indentation issues.

https://review.coreboot.org/#/c/20758/1/util/inteltool/cpu.c
File util/inteltool/cpu.c:

https://review.coreboot.org/#/c/20758/1/util/inteltool/cpu.c@35
PS1, Line 35: #define PRMRR_SUPPORTED	(1<<12)
Indentation is wrong


https://review.coreboot.org/#/c/20758/1/util/inteltool/cpu.c@64
PS1, Line 64: 			"mov %%ebx, %%edi;"
Same here.



-- 
To view, visit https://review.coreboot.org/20758
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1f5046c1f6703f5429c8717053ffe9c981cedf6f
Gerrit-Change-Number: 20758
Gerrit-PatchSet: 1
Gerrit-Owner: Pratikkumar V Prajapati <pratikkumar.v.prajapati at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Hannah Williams <hannah.williams at intel.com>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Tue, 25 Jul 2017 12:51:10 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170725/10eeb1b2/attachment.html>


More information about the coreboot-gerrit mailing list