[coreboot-gerrit] Change in coreboot[master]: src/vendorcode/amd/agesa/f15tn: Fix bitmask

Martin Roth (Code Review) gerrit at coreboot.org
Sun Jul 23 01:51:58 CEST 2017


Martin Roth has uploaded this change for review. ( https://review.coreboot.org/20699


Change subject: src/vendorcode/amd/agesa/f15tn: Fix bitmask
......................................................................

src/vendorcode/amd/agesa/f15tn: Fix bitmask

Fixes GCC 7.1 error:
error: '<<' in boolean context, did you mean '<' ?

Change-Id: I1a28522279982b30d25f1a4a4433a1db767f8a02
Signed-off-by: Martin Roth <martinroth at google.com>
---
M src/vendorcode/amd/agesa/f15tn/Proc/Fch/Pcie/GppHp.c
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/20699/1

diff --git a/src/vendorcode/amd/agesa/f15tn/Proc/Fch/Pcie/GppHp.c b/src/vendorcode/amd/agesa/f15tn/Proc/Fch/Pcie/GppHp.c
index b3d0c8b..898ff0c 100644
--- a/src/vendorcode/amd/agesa/f15tn/Proc/Fch/Pcie/GppHp.c
+++ b/src/vendorcode/amd/agesa/f15tn/Proc/Fch/Pcie/GppHp.c
@@ -85,7 +85,7 @@
 
   FailedPort = (UINT8) (1 << HpPort);
   if (FchGpp->GppGen2 && FchGpp->GppGen2Strap) {
-    GppS3Data &= (UINT8) !(1 << HpPort);
+    GppS3Data &= (UINT8) ~(1 << HpPort);
     if (GppPortPollingLtssm (FchGpp, FailedPort, TRUE, StdHeader)) {
       FchGppForceGen1 (FchGpp, FailedPort, StdHeader);
       FailedPort = GppPortPollingLtssm (FchGpp, FailedPort, FALSE, StdHeader);
@@ -123,7 +123,7 @@
   GppS3Data = 0x00;
   ReadMem ( ACPI_MMIO_BASE + CMOS_RAM_BASE + 0x0D, AccessWidth8, &GppS3Data);
   FchGpp->PortCfg[HpPort].PortDetected = FALSE;
-  GppS3Data &= (UINT8) !(1 << (HpPort + 4));
+  GppS3Data &= (UINT8) ~(1 << (HpPort + 4));
 
   if (FchGpp->GppGen2 && FchGpp->GppGen2Strap) {
     FchGppForceGen2 (FchGpp, (UINT8) (1 << HpPort), StdHeader);

-- 
To view, visit https://review.coreboot.org/20699
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1a28522279982b30d25f1a4a4433a1db767f8a02
Gerrit-Change-Number: 20699
Gerrit-PatchSet: 1
Gerrit-Owner: Martin Roth <martinroth at google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170722/c694bfa5/attachment-0001.html>


More information about the coreboot-gerrit mailing list