[coreboot-gerrit] Change in coreboot[master]: vendorcode/amd/agesa: f15tn & f16kb: fix assert
Martin Roth (Code Review)
gerrit at coreboot.org
Sun Jul 23 01:46:18 CEST 2017
Martin Roth has uploaded this change for review. ( https://review.coreboot.org/20698
Change subject: vendorcode/amd/agesa: f15tn & f16kb: fix assert
......................................................................
vendorcode/amd/agesa: f15tn & f16kb: fix assert
Fixes warning by GCC 7.1:
note: did you mean to use logical not?
Change-Id: If8167c6fe88135ae89eb795eeda09e6937b1684f
Signed-off-by: Martin Roth <martinroth at google.com>
---
M src/vendorcode/amd/agesa/f15tn/Proc/IDS/Library/IdsLib.c
M src/vendorcode/amd/agesa/f16kb/Proc/IDS/Library/IdsLib.c
2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/20698/1
diff --git a/src/vendorcode/amd/agesa/f15tn/Proc/IDS/Library/IdsLib.c b/src/vendorcode/amd/agesa/f15tn/Proc/IDS/Library/IdsLib.c
index b6867c5..34a12a7 100644
--- a/src/vendorcode/amd/agesa/f15tn/Proc/IDS/Library/IdsLib.c
+++ b/src/vendorcode/amd/agesa/f15tn/Proc/IDS/Library/IdsLib.c
@@ -698,7 +698,7 @@
IDS_EARLY_AP_TASK IdsEarlyTask;
IdentifyCore (StdHeader, &BscSocket, &IgnoredModule, &BscCoreNum, &IgnoredSts);
- ASSERT (~((Socket == BscSocket) && (Core == BscCoreNum)));
+ ASSERT (!((Socket == BscSocket) && (Core == BscCoreNum)));
if ((Socket == BscSocket) || (Core == 0)) {
ApUtilRunCodeOnSocketCore (Socket, Core, ApTask, StdHeader);
} else {
diff --git a/src/vendorcode/amd/agesa/f16kb/Proc/IDS/Library/IdsLib.c b/src/vendorcode/amd/agesa/f16kb/Proc/IDS/Library/IdsLib.c
index 2345e1c..0cb0a63 100644
--- a/src/vendorcode/amd/agesa/f16kb/Proc/IDS/Library/IdsLib.c
+++ b/src/vendorcode/amd/agesa/f16kb/Proc/IDS/Library/IdsLib.c
@@ -781,7 +781,7 @@
IDS_EARLY_AP_TASK IdsEarlyTask;
IdentifyCore (StdHeader, &BscSocket, &IgnoredModule, &BscCoreNum, &IgnoredSts);
- ASSERT (~((Socket == BscSocket) && (Core == BscCoreNum)));
+ ASSERT (!((Socket == BscSocket) && (Core == BscCoreNum)));
if ((Socket == BscSocket) || (Core == 0)) {
ApUtilRunCodeOnSocketCore (Socket, Core, ApTask, StdHeader);
} else {
--
To view, visit https://review.coreboot.org/20698
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If8167c6fe88135ae89eb795eeda09e6937b1684f
Gerrit-Change-Number: 20698
Gerrit-PatchSet: 1
Gerrit-Owner: Martin Roth <martinroth at google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170722/56178314/attachment.html>
More information about the coreboot-gerrit
mailing list