[coreboot-gerrit] Change in coreboot[master]: asus/p2b-ls: Drop onboard LAN from devicetree.cb

[Keith Hui (Code Review)]

Keith Hui has posted comments on this change. ( https://review.coreboot.org/20683 )

Change subject: asus/p2b-ls: Drop onboard LAN from devicetree.cb
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/20683/1//COMMIT_MSG
Commit Message:

https://review.coreboot.org/#/c/20683/1//COMMIT_MSG@11
PS1, Line 11: 
> It's probably not required because it's found during the scan.  Is there so
There was once a time when I had to remove this entry for ethernet to work at all which I noted in our wiki at the time. Our wiki says a devicetree.cb entry is needed when a device requires special init [1] which the onboard LAN doesn't.

Removing this entry allows this mainboard to support P2B-S which is the same circuit board without ethernet.

[1] https://www.coreboot.org/Creating_A_devicetree.cb



-- 
To view, visit https://review.coreboot.org/20683
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iabdf1a1ff3c904bea1b7b5eaefb1d23831dd2cb9
Gerrit-Change-Number: 20683
Gerrit-PatchSet: 1
Gerrit-Owner: Keith Hui <buurin at gmail.com>
Gerrit-Reviewer: Keith Hui <buurin at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Fri, 21 Jul 2017 22:42:32 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170721/67d30cbd/attachment.html>