[coreboot-gerrit] Change in coreboot[master]: mainboard/google/{poppy, soraka}: Enable S0ix

[Furquan Shaikh (Code Review)]

Hello Rajat Jain,

I'd like you to do a code review. Please visit

    https://review.coreboot.org/20689

to review the following change.


Change subject: mainboard/google/{poppy,soraka}: Enable S0ix
......................................................................

mainboard/google/{poppy,soraka}: Enable S0ix

Enable S0ix for poppy and soraka in their device trees respectively.

BUG=b:36630881
BRANCH=none
TEST=Verified S0ix and S3 operation on Poppy and Soraka (250+ iterations).

Change-Id: I9ba91499e54f729970448af6f71804ad5b3cb836
Signed-off-by: Rajat Jain <rajatja at google.com>
Signed-off-by: Furquan Shaikh <furquan at chromium.org>
---
M src/mainboard/google/poppy/variants/baseboard/devicetree.cb
M src/mainboard/google/poppy/variants/soraka/devicetree.cb
2 files changed, 6 insertions(+), 0 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/20689/1

diff --git a/src/mainboard/google/poppy/variants/baseboard/devicetree.cb b/src/mainboard/google/poppy/variants/baseboard/devicetree.cb
index 789b21a7..cabf3de 100644
--- a/src/mainboard/google/poppy/variants/baseboard/devicetree.cb
+++ b/src/mainboard/google/poppy/variants/baseboard/devicetree.cb
@@ -24,6 +24,9 @@
 	# Enable DPTF
 	register "dptf_enable" = "1"
 
+	# Enable S0ix
+	register "s0ix_enable" = "1"
+
 	# FSP Configuration
 	register "ProbelessTrace" = "0"
 	register "EnableLan" = "0"
diff --git a/src/mainboard/google/poppy/variants/soraka/devicetree.cb b/src/mainboard/google/poppy/variants/soraka/devicetree.cb
index 9b8a18c..3de9854 100644
--- a/src/mainboard/google/poppy/variants/soraka/devicetree.cb
+++ b/src/mainboard/google/poppy/variants/soraka/devicetree.cb
@@ -24,6 +24,9 @@
 	# Enable DPTF
 	register "dptf_enable" = "1"
 
+	# Enable S0ix
+	register "s0ix_enable" = "1"
+
 	# FSP Configuration
 	register "ProbelessTrace" = "0"
 	register "EnableLan" = "0"

-- 
To view, visit https://review.coreboot.org/20689
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9ba91499e54f729970448af6f71804ad5b3cb836
Gerrit-Change-Number: 20689
Gerrit-PatchSet: 1
Gerrit-Owner: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Rajat Jain <rajatja at google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170721/3e2c6f2e/attachment.html>