[coreboot-gerrit] Change in coreboot[master]: KBL: Modified FSP-S header with new UPD SpiFlashCfgLockDown

Barnali Sarkar (Code Review) gerrit at coreboot.org
Fri Jul 21 11:59:15 CEST 2017


Barnali Sarkar has uploaded this change for review. ( https://review.coreboot.org/20644


Change subject: KBL: Modified FSP-S header with new UPD SpiFlashCfgLockDown
......................................................................

KBL: Modified FSP-S header with new UPD SpiFlashCfgLockDown

This change is going to come in FSP in the next FSP release.
This patch is pushed to urgently fix he SPI FPR locking issue.

CQ-DEPEND=CL:*414049
BUG=63049493
BRANCH=none
TEST=Built and Boot poppy

Change-Id: I4725506103781a358b18ee70f4fdd56bf4ab3d96
Signed-off-by: Barnali Sarkar <barnali.sarkar at intel.com>
---
M src/vendorcode/intel/fsp/fsp2_0/skykabylake/FspsUpd.h
1 file changed, 9 insertions(+), 2 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/20644/2

diff --git a/src/vendorcode/intel/fsp/fsp2_0/skykabylake/FspsUpd.h b/src/vendorcode/intel/fsp/fsp2_0/skykabylake/FspsUpd.h
index e91bc79..b3c7698 100644
--- a/src/vendorcode/intel/fsp/fsp2_0/skykabylake/FspsUpd.h
+++ b/src/vendorcode/intel/fsp/fsp2_0/skykabylake/FspsUpd.h
@@ -165,9 +165,16 @@
 **/
   UINT8                       ShowSpiController;
 
-/** Offset 0x0036
+/** Offset 0x0036 - Flash Configuration Lock Down
+  Enable/disable flash lock down. If platform decides to skip this programming, it
+  must lock SPI flash register before end of post.
+  $EN_DIS
 **/
-  UINT8                       UnusedUpdSpace0[2];
+  UINT8                       SpiFlashCfgLockDown;
+
+/** Offset 0x0037
+**/
+  UINT8                       UnusedUpdSpace0;
 
 /** Offset 0x0038 - MicrocodeRegionBase
   Memory Base of Microcode Updates

-- 
To view, visit https://review.coreboot.org/20644
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4725506103781a358b18ee70f4fdd56bf4ab3d96
Gerrit-Change-Number: 20644
Gerrit-PatchSet: 2
Gerrit-Owner: Barnali Sarkar <barnali.sarkar at intel.com>
Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan at intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170721/429acb50/attachment.html>


More information about the coreboot-gerrit mailing list