[coreboot-gerrit] Change in coreboot[master]: mainboard/google/poppy/variants/soraka: Update GPP_{D1, D2, B7} config

Furquan Shaikh (Code Review) gerrit at coreboot.org
Fri Jul 21 00:39:43 CEST 2017


Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/20672


Change subject: mainboard/google/poppy/variants/soraka: Update GPP_{D1,D2,B7} config
......................................................................

mainboard/google/poppy/variants/soraka: Update GPP_{D1,D2,B7} config

GPP_B7, GPP_D1 and GPP_D2 are not used going forward. Mark them as NC
in gpio table.

BUG=b:62322846,b:62240755

Change-Id: I7aee08314e6ce96d5913ae315bf75f5c04ab7370
Signed-off-by: Furquan Shaikh <furquan at chromium.org>
---
M src/mainboard/google/poppy/variants/soraka/gpio.c
1 file changed, 6 insertions(+), 6 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/20672/1

diff --git a/src/mainboard/google/poppy/variants/soraka/gpio.c b/src/mainboard/google/poppy/variants/soraka/gpio.c
index 2189b6c..2a922a9 100644
--- a/src/mainboard/google/poppy/variants/soraka/gpio.c
+++ b/src/mainboard/google/poppy/variants/soraka/gpio.c
@@ -76,8 +76,8 @@
 	PAD_CFG_NC(GPP_B5),
 	/* B6  : SRCCLKREQ1# ==> WLAN_PCIE_CLKREQ_L */
 	PAD_CFG_NF(GPP_B6, NONE, DEEP, NF1),
-	/* B7  : SRCCLKREQ2# ==> WWAN_PCIE_CLKREQ_L */
-	PAD_CFG_NF(GPP_B7, NONE, DEEP, NF1),
+	/* B7  : SRCCLKREQ2# ==> NC */
+	PAD_CFG_NC(GPP_B7),
 	/* B8  : SRCCLKREQ3# ==> NC */
 	PAD_CFG_NC(GPP_B8),
 	/* B9  : SRCCLKREQ4# ==> NC */
@@ -180,10 +180,10 @@
 
 	/* D0  : SPI1_CS# ==> NC */
 	PAD_CFG_NC(GPP_D0),
-	/* D1  : SPI1_CLK ==> PEN_IRQ_L */
-	PAD_CFG_GPI_APIC(GPP_D1, NONE, PLTRST),
-	/* D2  : SPI1_MISO ==> PEN_PDCT_L */
-	PAD_CFG_GPI(GPP_D2, NONE, DEEP),
+	/* D1  : SPI1_CLK ==> NC */
+	PAD_CFG_NC(GPP_D1),
+	/* D2  : SPI1_MISO ==> NC */
+	PAD_CFG_NC(GPP_D2),
 	/* D3  : SPI1_MOSI ==> NC */
 	PAD_CFG_NC(GPP_D3),
 	/* D4  : FASHTRIG ==> NC */

-- 
To view, visit https://review.coreboot.org/20672
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7aee08314e6ce96d5913ae315bf75f5c04ab7370
Gerrit-Change-Number: 20672
Gerrit-PatchSet: 1
Gerrit-Owner: Furquan Shaikh <furquan at google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170720/ac2705cb/attachment-0001.html>


More information about the coreboot-gerrit mailing list