[coreboot-gerrit] Change in coreboot[master]: depthcharge: Update build

Marshall Dawson (Code Review) gerrit at coreboot.org
Thu Jul 20 20:06:12 CEST 2017


Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/20667 )

Change subject: depthcharge: Update build
......................................................................


Patch Set 2: Code-Review+2

(1 comment)

https://review.coreboot.org/#/c/20667/2/payloads/external/depthcharge/Kconfig
File payloads/external/depthcharge/Kconfig:

https://review.coreboot.org/#/c/20667/2/payloads/external/depthcharge/Kconfig@39
PS2, Line 39: bool
I can't remember if we ever decided to use "default n" or if readers should infer a default of n.  I'm meh.



-- 
To view, visit https://review.coreboot.org/20667
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I46fc2822cf93c821b402e8961ceecedc088f486c
Gerrit-Change-Number: 20667
Gerrit-PatchSet: 2
Gerrit-Owner: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Evelyn Huang <evhuang at google.com>
Gerrit-Reviewer: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Thu, 20 Jul 2017 18:06:12 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170720/be6723f2/attachment.html>


More information about the coreboot-gerrit mailing list