[coreboot-gerrit] Change in coreboot[master]: depthcharge: Update build
Martin Roth (Code Review)
gerrit at coreboot.org
Thu Jul 20 17:22:01 CEST 2017
Hello Evelyn Huang, Marshall Dawson, build bot (Jenkins), Marc Jones, Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/20667
to look at the new patch set (#2).
Change subject: depthcharge: Update build
......................................................................
depthcharge: Update build
- Add prompt so the defconfig can be selected for the build.
- Remove target rename code from makefile. The old versions don't build
with the latest vboot, so this isn't useful anymore.
- Change $(info ...) to an echo. info prints immediately when
evaluated, which made it print when it shouldn't have, on make clean
for example.
- Split up single line shell scripts into multiple lines
- Change checkout target to only update the commit id when actually
changing versions instead of on every build.
Change-Id: I46fc2822cf93c821b402e8961ceecedc088f486c
Signed-off-by: Martin Roth <martinroth at google.com>
---
M payloads/external/depthcharge/Kconfig
M payloads/external/depthcharge/Makefile
2 files changed, 31 insertions(+), 23 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/20667/2
--
To view, visit https://review.coreboot.org/20667
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I46fc2822cf93c821b402e8961ceecedc088f486c
Gerrit-Change-Number: 20667
Gerrit-PatchSet: 2
Gerrit-Owner: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Evelyn Huang <evhuang at google.com>
Gerrit-Reviewer: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170720/e3ecefa5/attachment.html>
More information about the coreboot-gerrit
mailing list