[coreboot-gerrit] Change in coreboot[master]: libpayload: Fix unaligned buffer logic in default_memset
Marshall Dawson (Code Review)
gerrit at coreboot.org
Thu Jul 20 00:27:22 CEST 2017
Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/20655 )
Change subject: libpayload: Fix unaligned buffer logic in default_memset
......................................................................
Patch Set 1:
This broke for me at https://review.coreboot.org/#/c/20524/ . I would be curious whether that patch is still necessary after this went in https://review.coreboot.org/#/c/20528/ . It seemed to me that romstage had a misaligned stack for Intel-based Chromebooks but it apparently wasn't causing an issue. I assume that misalignment could eventually potentially propagate to the payload.
--
To view, visit https://review.coreboot.org/20655
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I862671bbe7efa8d370d0148e22ea55407e260053
Gerrit-Change-Number: 20655
Gerrit-PatchSet: 1
Gerrit-Owner: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella at gmail.com>
Gerrit-Reviewer: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Wed, 19 Jul 2017 22:27:22 +0000
Gerrit-HasComments: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170719/ca286124/attachment.html>
More information about the coreboot-gerrit
mailing list