[coreboot-gerrit] Change in libgfxinit[master]: gma skl: Prevent race by late timeout check

Nico Huber (Code Review) gerrit at coreboot.org
Wed Jul 19 14:57:34 CEST 2017


Nico Huber has uploaded a new patch set (#2). ( https://review.coreboot.org/20647 )

Change subject: gma skl: Prevent race by late timeout check
......................................................................

gma skl: Prevent race by late timeout check

We initialized a timeout variable before the first event on the other
side (i.e. us sending a request to PCODE). With very slow debug output
sending the request itself might take longer than the timeout period.

Reorder the code to check the timeout condition only after the first
try and thereby make sure that we always try at least twice. Also issue
a debug message in case we timed out.

Change-Id: I8cdeb3e36d7eafbef8a1a8e13670f3f9838a2f38
Signed-off-by: Nico Huber <nico.huber at secunet.com>
---
M common/skylake/hw-gfx-gma-power_and_clocks_skylake.adb
1 file changed, 7 insertions(+), 4 deletions(-)


  git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/47/20647/2
-- 
To view, visit https://review.coreboot.org/20647
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: libgfxinit
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8cdeb3e36d7eafbef8a1a8e13670f3f9838a2f38
Gerrit-Change-Number: 20647
Gerrit-PatchSet: 2
Gerrit-Owner: Nico Huber <nico.h at gmx.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170719/bf7db0a9/attachment.html>


More information about the coreboot-gerrit mailing list