[coreboot-gerrit] Change in coreboot[master]: Allow to enable MULTIPLE_VGA_ADAPTERS for G505S without edit...

[Martin Roth (Code Review)]

Martin Roth has posted comments on this change. ( https://review.coreboot.org/20638 )

Change subject: Allow to enable MULTIPLE_VGA_ADAPTERS for G505S without editing Kconfig
......................................................................


Patch Set 2:

(3 comments)

https://review.coreboot.org/#/c/20638/2/src/device/Kconfig
File src/device/Kconfig:

https://review.coreboot.org/#/c/20638/2/src/device/Kconfig@246
PS2, Line 246: depends on BOARD_LENOVO_G505S
Remove this?  It will make it so that the G505s is the only board that can enable this feature.


https://review.coreboot.org/#/c/20638/2/src/device/Kconfig@247
PS2, Line 247: n
I'm not seeing any reason not to default this to y, or or even get rid of the Kconfig option completely and just have all the code protected by the option always run.

Nico - Thoughts?


https://review.coreboot.org/#/c/20638/2/src/device/Kconfig@251
PS2, Line 251: '
its - the apostrophe isn't needed.



-- 
To view, visit https://review.coreboot.org/20638
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iade58d3c373e0bc30d4642d9417c4e5224249136
Gerrit-Change-Number: 20638
Gerrit-PatchSet: 2
Gerrit-Owner: Mike Banon <mikebdp2 at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Tue, 18 Jul 2017 22:21:24 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170718/4de48937/attachment.html>