[coreboot-gerrit] Change in coreboot[master]: Kconfig: Move libhwbase related options into lib/Kconfig

Nico Huber (Code Review) gerrit at coreboot.org
Mon Jul 17 23:30:20 CEST 2017


Nico Huber has uploaded this change for review. ( https://review.coreboot.org/20625


Change subject: Kconfig: Move libhwbase related options into lib/Kconfig
......................................................................

Kconfig: Move libhwbase related options into lib/Kconfig

More will follow so better move them where they are used. Also remove
defaults and add dependencies to not clutter .config files up that
don't have any of these options selected.

Change-Id: I3a255c821cc26aeb66e4fd6adf7142d7e856f5ac
Signed-off-by: Nico Huber <nico.h at gmx.de>
---
M src/Kconfig
M src/lib/Kconfig
2 files changed, 18 insertions(+), 14 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/20625/1

diff --git a/src/Kconfig b/src/Kconfig
index 637f575..701b2b4 100644
--- a/src/Kconfig
+++ b/src/Kconfig
@@ -1145,20 +1145,6 @@
 	  required and not implemented if a weak implementation is found in the
 	  resulting image.
 
-config RAMSTAGE_ADA
-	def_bool n
-	help
-	  Selected by features that use Ada code in ramstage.
-
-config RAMSTAGE_LIBHWBASE
-	def_bool n
-	select RAMSTAGE_ADA
-	help
-	  Selected by features that require `libhwbase` in ramstage.
-
-config HWBASE_DYNAMIC_MMIO
-	def_bool y
-
 config UNCOMPRESSED_RAMSTAGE
 	bool
 
diff --git a/src/lib/Kconfig b/src/lib/Kconfig
index 6d5f034..a1034a9 100644
--- a/src/lib/Kconfig
+++ b/src/lib/Kconfig
@@ -5,3 +5,21 @@
 	  Don't include default fill_lb_framebuffer() implementation. Select
 	  this if your drivers uses MAINBOARD_DO_NATIVE_VGA_INIT but provides
 	  its own fill_lb_framebuffer() implementation.
+
+config RAMSTAGE_ADA
+	bool
+	help
+	  Selected by features that use Ada code in ramstage.
+
+config RAMSTAGE_LIBHWBASE
+	bool
+	select RAMSTAGE_ADA
+	help
+	  Selected by features that require `libhwbase` in ramstage.
+
+if RAMSTAGE_LIBHWBASE
+
+config HWBASE_DYNAMIC_MMIO
+	def_bool y
+
+endif

-- 
To view, visit https://review.coreboot.org/20625
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3a255c821cc26aeb66e4fd6adf7142d7e856f5ac
Gerrit-Change-Number: 20625
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber <nico.h at gmx.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170717/45255836/attachment-0001.html>


More information about the coreboot-gerrit mailing list