[coreboot-gerrit] Change in coreboot[master]: soc/intel/skylake: Perform SPI offset read for posted write

Subrata Banik (Code Review) gerrit at coreboot.org
Mon Jul 17 13:43:38 CEST 2017


Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/20616


Change subject: soc/intel/skylake: Perform SPI offset read for posted write
......................................................................

soc/intel/skylake: Perform SPI offset read for posted write

As per programming guide, need to perform pci offset 0xDC
read back for posted write to take effect.

Change-Id: I1f8f31c524909d83324f6d7696ca6cfef08a7e38
Signed-off-by: Subrata Banik <subrata.banik at intel.com>
---
M src/soc/intel/skylake/finalize.c
1 file changed, 3 insertions(+), 0 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/20616/1

diff --git a/src/soc/intel/skylake/finalize.c b/src/soc/intel/skylake/finalize.c
index 171d92e..30f0b09 100644
--- a/src/soc/intel/skylake/finalize.c
+++ b/src/soc/intel/skylake/finalize.c
@@ -175,6 +175,9 @@
 
 		fast_spi_set_bios_interface_lock_down();
 
+		/* Reads back for posted write to take effect */
+		fast_spi_get_bios_control_reg();
+
 		/* GCS reg of DMI */
 		pcr_or8(PID_DMI, PCR_DMI_GCS, PCR_DMI_GCS_BILD);
 	}

-- 
To view, visit https://review.coreboot.org/20616
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1f8f31c524909d83324f6d7696ca6cfef08a7e38
Gerrit-Change-Number: 20616
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik <subrata.banik at intel.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170717/c7c92674/attachment.html>


More information about the coreboot-gerrit mailing list