[coreboot-gerrit] Change in coreboot[master]: google/gru: Add support for Scarlet rev1

[David Schneider (Code Review)]

David Schneider has posted comments on this change. ( https://review.coreboot.org/20587 )

Change subject: google/gru: Add support for Scarlet rev1
......................................................................


Patch Set 2:

(2 comments)

https://review.coreboot.org/#/c/20587/2/src/mainboard/google/gru/mainboard.c
File src/mainboard/google/gru/mainboard.c:

https://review.coreboot.org/#/c/20587/2/src/mainboard/google/gru/mainboard.c@341
PS2, Line 341: /* no WIFI_PD# line */
scarlet has a wlan_pd_1v8_l line


https://review.coreboot.org/#/c/20587/2/src/mainboard/google/gru/mainboard.c@343
PS2, Line 343: only one USB port
I'm confused by the polarity of these comments, but maybe that's just me.



-- 
To view, visit https://review.coreboot.org/20587
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7a7cc11d9387ac1d856663326e35cfa5371e0af2
Gerrit-Change-Number: 20587
Gerrit-PatchSet: 2
Gerrit-Owner: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: David Schneider <dnschneid at chromium.org>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Lin Huang <hl at rock-chips.com>
Gerrit-Reviewer: Philip Chen <philipchen at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Fri, 14 Jul 2017 23:59:50 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170714/eb81cc31/attachment.html>