[coreboot-gerrit] Change in coreboot[master]: rockchip/rk3399: Adjust gpio_t format to match ARM TF

Julius Werner (Code Review) gerrit at coreboot.org
Sat Jul 15 00:17:21 CEST 2017


Hello Philip Chen, build bot (Jenkins), 

I'd like you to reexamine a change. Please visit

    https://review.coreboot.org/20586

to look at the new patch set (#2).

Change subject: rockchip/rk3399: Adjust gpio_t format to match ARM TF
......................................................................

rockchip/rk3399: Adjust gpio_t format to match ARM TF

Our structure packing for Rockchip's gpio_t was chosen arbitrarily. ARM
Trusted Firmware has since become a thing and chosen a slightly
different way to represent GPIOs in a 32-bit word. Let's align our
format to them so we don't need to remember to convert the values every
time we pass them through.

CQ-DEPEND=CL:572228

Change-Id: I9ce33da28ee8a34d2d944bee010d8bfc06fe879b
Signed-off-by: Julius Werner <jwerner at chromium.org>
---
M src/mainboard/google/gru/mainboard.c
M src/soc/rockchip/common/include/soc/gpio.h
2 files changed, 11 insertions(+), 13 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/20586/2
-- 
To view, visit https://review.coreboot.org/20586
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9ce33da28ee8a34d2d944bee010d8bfc06fe879b
Gerrit-Change-Number: 20586
Gerrit-PatchSet: 2
Gerrit-Owner: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Philip Chen <philipchen at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170714/f3b75d3c/attachment.html>


More information about the coreboot-gerrit mailing list