[coreboot-gerrit] Change in coreboot[master]: siemens/nc_fpga: Fix wrong type cast

Werner Zeh (Code Review) gerrit at coreboot.org
Fri Jul 14 10:33:34 CEST 2017


Werner Zeh has uploaded this change for review. ( https://review.coreboot.org/20572


Change subject: siemens/nc_fpga: Fix wrong type cast
......................................................................

siemens/nc_fpga: Fix wrong type cast

As "var" is not a pointer but a variable there is no need to cast it to
a pointer before using the value.

Change-Id: I7f8e3ceadaa4301c50c5f5480cccab2be904aa9a
Signed-off-by: Werner Zeh <werner.zeh at siemens.com>
---
M src/drivers/siemens/nc_fpga/nc_fpga.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/20572/1

diff --git a/src/drivers/siemens/nc_fpga/nc_fpga.c b/src/drivers/siemens/nc_fpga/nc_fpga.c
index 15b3ad3..ab44e23 100644
--- a/src/drivers/siemens/nc_fpga/nc_fpga.c
+++ b/src/drivers/siemens/nc_fpga/nc_fpga.c
@@ -28,7 +28,7 @@
 { \
 	uint32_t var; \
 	if (hwilib_get_field(src, (uint8_t *)&var, sizeof(var))) \
-		dst = *((typeof(dst) *)var); \
+		dst = ((typeof(dst))var); \
 }
 
 static void init_temp_mon (void *base_adr)

-- 
To view, visit https://review.coreboot.org/20572
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7f8e3ceadaa4301c50c5f5480cccab2be904aa9a
Gerrit-Change-Number: 20572
Gerrit-PatchSet: 1
Gerrit-Owner: Werner Zeh <werner.zeh at siemens.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170714/9f035b13/attachment-0001.html>


More information about the coreboot-gerrit mailing list