[coreboot-gerrit] Change in coreboot[master]: mb/google/eve: Disable SMBus

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/20559 )

Change subject: mb/google/eve: Disable SMBus
......................................................................


Patch Set 2:

I guess if we disable SMBUS as UPD policy then from FSP Silicon init phase, this will make SMBUS function disable which mean device will not visible over bus after FSP-S exit.

But if you see inside pmunil.c we need to get access of TCO base from smbus pci config space as its part of SMBUS space unlike BDW where it was part of PMC. I don't think we can disable SMBUS.


-- 
To view, visit https://review.coreboot.org/20559
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3db28bb22245a2f1d39b4f795a3f438a9df36a2c
Gerrit-Change-Number: 20559
Gerrit-PatchSet: 2
Gerrit-Owner: Naresh Solanki <naresh.solanki at intel.com>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi at intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Thu, 13 Jul 2017 05:04:12 +0000
Gerrit-HasComments: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170713/e68b7285/attachment.html>