[coreboot-gerrit] Change in coreboot[master]: util/cbfstool: demote FV handling errors to debug

Patrick Georgi (Code Review) gerrit at coreboot.org
Wed Jul 5 13:49:00 CEST 2017


Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/20469


Change subject: util/cbfstool: demote FV handling errors to debug
......................................................................

util/cbfstool: demote FV handling errors to debug

It's rather normal that a few bytes are skipped.

Change-Id: I9371afdbb3ad05de7645bfbf257e4f4bfa2feddb
Signed-off-by: Patrick Georgi <pgeorgi at google.com>
---
M util/cbfstool/cbfs-mkpayload.c
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/20469/1

diff --git a/util/cbfstool/cbfs-mkpayload.c b/util/cbfstool/cbfs-mkpayload.c
index 45d36f4..fd2c4ca 100644
--- a/util/cbfstool/cbfs-mkpayload.c
+++ b/util/cbfstool/cbfs-mkpayload.c
@@ -320,7 +320,7 @@
 	fh = (ffs_file_header_t *)(input->data + fv->header_length);
 	while (fh->file_type == FILETYPE_PAD) {
 		unsigned long offset = (fh->size[2] << 16) | (fh->size[1] << 8) | fh->size[0];
-		ERROR("skipping %lu bytes of FV padding\n", offset);
+		DEBUG("skipping %lu bytes of FV padding\n", offset);
 		fh = (ffs_file_header_t *)(((uintptr_t)fh) + offset);
 	}
 	if (fh->file_type != FILETYPE_SEC) {
@@ -332,7 +332,7 @@
 	cs = (common_section_header_t *)&fh[1];
 	while (cs->section_type == SECTION_RAW) {
 		unsigned long offset = (cs->size[2] << 16) | (cs->size[1] << 8) | cs->size[0];
-		ERROR("skipping %lu bytes of section padding\n", offset);
+		DEBUG("skipping %lu bytes of section padding\n", offset);
 		cs = (common_section_header_t *)(((uintptr_t)cs) + offset);
 	}
 	if (cs->section_type != SECTION_PE32) {

-- 
To view, visit https://review.coreboot.org/20469
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9371afdbb3ad05de7645bfbf257e4f4bfa2feddb
Gerrit-Change-Number: 20469
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Georgi <pgeorgi at google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170705/d817f618/attachment.html>


More information about the coreboot-gerrit mailing list