[coreboot-gerrit] Change in coreboot[master]: util/intelmetool: Add bootguard information dump support

[Philipp Deppenwiese (Code Review)]

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/16328 )

Change subject: util/intelmetool: Add bootguard information dump support
......................................................................


Patch Set 21:

(5 comments)

@Nicola which bits 20:21 and where do we get them. Normally the bootguard enforcement policies are somewhere in the ME pci config space  but we don't know where exactly. If you have information about it please give me some input or make modifications yourself.

https://review.coreboot.org/#/c/16328/9/util/intelmetool/intelmetool.c
File util/intelmetool/intelmetool.c:

https://review.coreboot.org/#/c/16328/9/util/intelmetool/intelmetool.c@129
PS9, Line 129: 
> you have ME hardware on board but...
Done


https://review.coreboot.org/#/c/16328/9/util/intelmetool/msr.c
File util/intelmetool/msr.c:

https://review.coreboot.org/#/c/16328/9/util/intelmetool/msr.c@29
PS9, Line 29: static uint64_t rdmsr(int addr)
> static int ...
Done


https://review.coreboot.org/#/c/16328/9/util/intelmetool/msr.c@60
PS9, Line 60: 
> include errno.h instead of hardcoding values
Done


https://review.coreboot.org/#/c/16328/9/util/intelmetool/msr.c@73
PS9, Line 73: #endif
> Return error code and pass msr value by argument
Done


https://review.coreboot.org/#/c/16328/9/util/intelmetool/msr.c@85
PS9, Line 85: 
> O_RDONLY
Done



-- 
To view, visit https://review.coreboot.org/16328
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifeec8e20fa8efc35d7db4c6a84be1f118dccfc4a
Gerrit-Change-Number: 16328
Gerrit-PatchSet: 21
Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: Alexander Couzens <lynxis at fe80.eu>
Gerrit-Reviewer: Damien Zammit <damien at zamaudio.com>
Gerrit-Reviewer: Felix Held <felix-coreboot at felixheld.de>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Mathias Krause <minipli at googlemail.com>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Nicola Corna <nicola at corna.info>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: Philippe Mathieu-Daudé <f4bug at amsat.org>
Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar at intel.com>
Gerrit-Reviewer: Werner Zeh <werner.zeh at siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Mon, 03 Jul 2017 12:09:03 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170703/bc1c53e0/attachment.html>