[coreboot-gerrit] Patch merged into coreboot/master: mainboard/google/reef: Set edge triggered interrupt for GPIO_22

gerrit at coreboot.org gerrit at coreboot.org
Tue Jan 31 15:17:40 CET 2017


the following patch was just integrated into master:
commit 6e5609124eb98b2f3e33fcec994b7d1b00a355ef
Author: Vaibhav Shankar <vaibhav.shankar at intel.com>
Date:   Mon Jan 30 12:18:42 2017 -0800

    mainboard/google/reef: Set edge triggered interrupt for GPIO_22
    
    EC sets the logic level based on outstanding wake events. When GPIO_22
    is configured as a level triggered interrupt, the events are not
    cleared from the interrupt handler. Hence, we'd just be re-signalling
    over and over causing an interrupt storm upon lid open. So, GPIO_22
    needs to be configured as EDGE_SINGLE instead of LEVEL.
    
    BUG=chrome-os-partner:62458
    TEST=Lid close/open. check CPU usage using top. It should
    not show 70% CPU usage.
    
    Signed-off-by: Vaibhav Shankar <vaibhav.shankar at intel.com>
    
    Change-Id: I710a690578c6e5b63be34b7fbcb21c703ef56e3a
    Reviewed-on: https://review.coreboot.org/18267
    Tested-by: build bot (Jenkins)
    Reviewed-by: Venkateswarlu V Vinjamuri <venkateswarlu.v.vinjamuri at intel.com>
    Reviewed-by: Aaron Durbin <adurbin at chromium.org>
    Reviewed-by: Paul Menzel <paulepanter at users.sourceforge.net>


See https://review.coreboot.org/18267 for details.

-gerrit



More information about the coreboot-gerrit mailing list