[coreboot-gerrit] New patch to review for coreboot: src/lib: Update Makefile to keep build/spd.bin rule private
Martin Roth (martinroth@google.com)
gerrit at coreboot.org
Mon Jan 30 02:15:35 CET 2017
Martin Roth (martinroth at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/18261
-gerrit
commit 39782a3a63deadb1734b7f0475a7af2a3e013b74
Author: Martin Roth <gaumless at gmail.com>
Date: Sun Jan 29 18:11:36 2017 -0700
src/lib: Update Makefile to keep build/spd.bin rule private
The rule to make spd.bin that's in src/lib is for the 'generic_spd_bin'
implementation. It wasn't guarded though, so it was generating a build
warning for any other platform that generated an spd.bin file.
Sample warning that this fixes:
src/mainboard/gizmosphere/gizmo/Makefile.inc:42:
warning: overriding recipe for target 'build/spd.bin'
src/lib/Makefile.inc:298: warning: ignoring old recipe for target
'build/spd.bin'
Change-Id: Iadd6743f8ae476969bf36f99b918f04c04172d1d
Signed-off-by: Martin Roth <gaumless at gmail.com>
---
src/lib/Makefile.inc | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/lib/Makefile.inc b/src/lib/Makefile.inc
index 9a9ddc8..38b3c12 100644
--- a/src/lib/Makefile.inc
+++ b/src/lib/Makefile.inc
@@ -287,6 +287,7 @@ ramstage-$(CONFIG_HAVE_MONOTONIC_TIMER) += hw-time-timer.adb
endif # CONFIG_RAMSTAGE_LIBHWBASE
+ifeq ($(CONFIG_GENERIC_SPD_BIN),y)
romstage-$(CONFIG_GENERIC_SPD_BIN) += spd_bin.c
LIB_SPD_BIN = $(obj)/spd.bin
@@ -304,3 +305,4 @@ $(LIB_SPD_BIN): $(LIB_SPD_DEPS)
cbfs-files-$(CONFIG_GENERIC_SPD_BIN) += spd.bin
spd.bin-file := $(LIB_SPD_BIN)
spd.bin-type := spd
+endif
More information about the coreboot-gerrit
mailing list