[coreboot-gerrit] Patch set updated for coreboot: mainboard/google/pryo: Update touchscreen device ACPI nodes

Aaron Durbin (adurbin@chromium.org) gerrit at coreboot.org
Sun Jan 29 21:15:33 CET 2017


Aaron Durbin (adurbin at chromium.org) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/18239

-gerrit

commit 7ce160b95c689d2a0761dd25b6648f47aa796eb7
Author: Furquan Shaikh <furquan at chromium.org>
Date:   Wed Jan 25 19:15:49 2017 -0800

    mainboard/google/pryo: Update touchscreen device ACPI nodes
    
    1. For ELAN, export reset GPIO as well as PowerResource
    2. For WCOM, export PowerResource
    
    BUG=chrome-os-partner:62311, chrome-os-partner:60194,
    chrome-os-partner:62371
    BRANCH=reef
    TEST=Verified that touchscreen works on pyro with WCOM device on
    power-on as well as after suspend/resume.
    
    Change-Id: I0306e24e19bf821cd3e08fdacc0d78b494c9a92f
    Signed-off-by: Furquan Shaikh <furquan at chromium.org>
---
 src/mainboard/google/reef/variants/pyro/devicetree.cb | 19 +++++++++++--------
 1 file changed, 11 insertions(+), 8 deletions(-)

diff --git a/src/mainboard/google/reef/variants/pyro/devicetree.cb b/src/mainboard/google/reef/variants/pyro/devicetree.cb
index 41086f0..72ad57c 100644
--- a/src/mainboard/google/reef/variants/pyro/devicetree.cb
+++ b/src/mainboard/google/reef/variants/pyro/devicetree.cb
@@ -187,6 +187,12 @@ chip soc/intel/apollolake
 					 .cid = PNP0C50_CID,
 					 .desc = WCOM_TS_DESC,
 					 .irq = IRQ_LEVEL_LOW(GPIO_21_IRQ),
+					 .reset_gpio = ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_36),
+					 .reset_delay_ms = 20,
+					 .enable_gpio = ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_152),
+					 .enable_delay_ms = 1,
+					 .has_power_resource = 1,
+					 .disable_gpio_export_in_crs = 1,
 				}"
 				register "hid_desc_reg_offset" = "0x1"
 				device i2c 0xA on end
@@ -196,14 +202,11 @@ chip soc/intel/apollolake
 				register "desc" = ""ELAN Touchscreen""
 				register "irq" = "IRQ_EDGE_LOW(GPIO_21_IRQ)"
 				register "probed" = "1"
-
-				chip drivers/generic/gpio_regulator
-					register "name" = ""vcc33""
-					register "gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_152)"
-					register "enabled_on_boot" = "1"
-					device generic 0 on end
-				end
-
+				register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_36)"
+				register "reset_delay_ms" = "20"
+				register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_152)"
+				register "enable_delay_ms" = "1"
+				register "has_power_resource" = "1"
 				device i2c 10 on end
 			end
 		end	# - I2C 3



More information about the coreboot-gerrit mailing list