[coreboot-gerrit] Patch set updated for coreboot: mainboard/google/reef: Set IOSSTATE for trackpad I2C GPIOs

Vaibhav Shankar (vaibhav.shankar@intel.com) gerrit at coreboot.org
Fri Jan 27 21:14:03 CET 2017


Vaibhav Shankar (vaibhav.shankar at intel.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/18251

-gerrit

commit 6f6f00210ec334d2119e37877e28281e2b51b26d
Author: Vaibhav Shankar <vaibhav.shankar at intel.com>
Date:   Fri Jan 27 11:37:30 2017 -0800

    mainboard/google/reef: Set IOSSTATE for trackpad I2C GPIOs
    
    I2C data (GPIO_132) and Clk (GPIO_133) lines are pulled low during
    standby states S3/S0ix. This causes leakage of power. To reduce the
    leakage, we have to pull these lines high during S3/S0ix. This is
    done by programming the IOSSTATE to HIz. Also note that we are using
    the internal pull ups to keep at SOC at 1.8V and the I2C lines are
    not floating.
    
    BUG=chrome-os-partner:62428,chrome-os-partner:61651
    TEST=Enter S3/S0ix. Measure trackpad power. It should be less
    than 4mW. Also I2c lines should be pulled high in S3/S0ix.
    
    Change-Id: I5570ac37ec3cc41f6463dd6b858fdb56a20a1733
    Signed-off-by: Vaibhav Shankar <vaibhav.shankar at intel.com>
---
 src/mainboard/google/reef/variants/baseboard/gpio.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/src/mainboard/google/reef/variants/baseboard/gpio.c b/src/mainboard/google/reef/variants/baseboard/gpio.c
index 390ef0f..3bb9a5f 100644
--- a/src/mainboard/google/reef/variants/baseboard/gpio.c
+++ b/src/mainboard/google/reef/variants/baseboard/gpio.c
@@ -101,8 +101,10 @@ static const struct pad_config gpio_table[] = {
 	PAD_CFG_NF(GPIO_131, UP_2K, DEEP, NF1), /* LPSS_I2C3_SCL */
 
 	/* I2C4 - trackpad */
-	PAD_CFG_NF(GPIO_132, UP_2K, DEEP, NF1), /* LPSS_I2C4_SDA */
-	PAD_CFG_NF(GPIO_133, UP_2K, DEEP, NF1), /* LPSS_I2C4_SCL */
+	/* LPSS_I2C4_SDA */
+	PAD_CFG_NF_IOSSTATE(GPIO_132, UP_2K, DEEP, NF1, HIZCRx1),
+	/* LPSS_I2C4_SCL */
+	PAD_CFG_NF_IOSSTATE(GPIO_133, UP_2K, DEEP, NF1, HIZCRx1),
 
 	/* I2C5 -- pen with external pulls  */
 	PAD_CFG_NF(GPIO_134, NONE, DEEP, NF1), /* LPSS_I2C5_SDA */



More information about the coreboot-gerrit mailing list