[coreboot-gerrit] New patch to review for coreboot: google/jecht: Fix LED for guado/rikku variants

[Matt DeVillier (matt.devillier@gmail.com)]

Matt DeVillier (matt.devillier at gmail.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/18249

-gerrit

commit 7b8dd5275f8fd7e39cfd78518370ceb075fe1dda
Author: Matt DeVillier <matt.devillier at gmail.com>
Date:   Thu Jan 26 10:58:15 2017 -0600

    google/jecht: Fix LED for guado/rikku variants
    
    When guado/rikku/tidus were rolled into jecht, an error was
    made in set_power_led() as guado/rikku set the polarity
    differently than tidus.  Fix the power LED for guado/rikku
    by setting the polarity correctly.
    
    Test: boot guado/rikku and observe proper function of power LED
    under S0, S3, and S5 power states.
    
    Change-Id: I23072ac60bc9683776f748ca1326d98257c3c54f
    Signed-off-by: Matt DeVillier <matt.devillier at gmail.com>
---
 src/mainboard/google/jecht/led.c | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/src/mainboard/google/jecht/led.c b/src/mainboard/google/jecht/led.c
index 50cf32e..286b65e 100644
--- a/src/mainboard/google/jecht/led.c
+++ b/src/mainboard/google/jecht/led.c
@@ -19,10 +19,18 @@
 
 void set_power_led(int state)
 {
+	int polarity;
+
+	if (IS_ENABLED(CONFIG_BOARD_GOOGLE_TIDUS)) {
+		polarity = state == LED_OFF ? 0x00 : 0x01;
+	} else {
+		polarity = state == LED_BLINK ? 0x01 : 0x00;
+	}
+
 	it8772f_gpio_led(IT8772F_GPIO_DEV,
 		1, 					/* set */
 		0x01, 					/* select */
-		state == LED_OFF ? 0x00 : 0x01,		/* polarity */
+		polarity,				/* polarity */
 		state == LED_BLINK ? 0x01 : 0x00,	/* pullup/pulldown */
 		0x01, 					/* output */
 		state == LED_BLINK ? 0x00 : 0x01,	/* I/O function */