[coreboot-gerrit] Patch merged into coreboot/master: Only add etc/ps2-keyboard-spinup when not updating an image

gerrit at coreboot.org gerrit at coreboot.org
Fri Jan 27 02:09:40 CET 2017


the following patch was just integrated into master:
commit 7218a1e754d84f84fd13bd5a66b38c6f0eb6f884
Author: Arthur Heymans <arthur at aheymans.xyz>
Date:   Wed Jan 25 15:21:08 2017 +0100

    Only add etc/ps2-keyboard-spinup when not updating an image
    
    Without this motherboards that requires a non zero timeout for ps2
    keyboards on SeaBIOS don't build when CONFIG_UPDATE_IMAGE is set.
    
    An alternative way to achieve this file would be to include a cbfsfile
    instead of calling cbfstool. That way the file gets updated/added both
    both image update and regular build. A difficulty of that approach is
    that it needs to convert a decimal to a binary in little endian
    representation, which is not a trivial thing to do in a Makefile.
    
    Change-Id: Icafba8d3e279a2e70e607abba81e3dbebfb55e4b
    Signed-off-by: Arthur Heymans <arthur at aheymans.xyz>
    Reviewed-on: https://review.coreboot.org/18231
    Tested-by: build bot (Jenkins)
    Reviewed-by: Martin Roth <martinroth at google.com>


See https://review.coreboot.org/18231 for details.

-gerrit



More information about the coreboot-gerrit mailing list