[coreboot-gerrit] New patch to review for coreboot: Makefile: Just error out if no .config exists

Martin Roth (martinroth@google.com) gerrit at coreboot.org
Thu Jan 26 18:52:03 CET 2017


Martin Roth (martinroth at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/18245

-gerrit

commit 7caa691b49bc5d0e9146bcdba606478b55de6f11
Author: Martin Roth <martinroth at google.com>
Date:   Thu Jan 26 10:51:43 2017 -0700

    Makefile: Just error out if no .config exists
    
    Currently coreboot runs the 'config' command if no .config file exists.
    This isn't what anyone wants, and is particularly frustrating for tools
    that automate the build, where the build just hangs waiting for input.
    
    Instead, just show an error message and then exit the build.
    
    Change-Id: If9e0c2c26f8273814518589a2f94c5b00fc4cefe
    Signed-off-by: Martin Roth <martinroth at google.com>
---
 Makefile | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/Makefile b/Makefile
index 2c87feb..2973030 100644
--- a/Makefile
+++ b/Makefile
@@ -123,8 +123,11 @@ endif
 ifeq ($(NOCOMPILE),1)
 include $(TOPLEVEL)/Makefile.inc
 include $(TOPLEVEL)/payloads/Makefile.inc
-real-all: config
-
+real-all:
+	@echo "Error: Expected config file ($(DOTCONFIG)) not present." >&2
+	@echo "Please specify a config file or run 'make menuconfig' to" >&2
+	@echo "generate a new config file." >&2
+	@exit 1
 else
 
 include $(DOTCONFIG)



More information about the coreboot-gerrit mailing list