[coreboot-gerrit] New patch to review for coreboot: mainboard/google/pryo: Update touchscreen device ACPI nodes

Furquan Shaikh (furquan@google.com) gerrit at coreboot.org
Thu Jan 26 04:12:07 CET 2017


Furquan Shaikh (furquan at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/18239

-gerrit

commit dd552c0129707132f96adcc540f226dd63c9a86b
Author: Furquan Shaikh <furquan at chromium.org>
Date:   Wed Jan 25 19:05:18 2017 -0800

    mainboard/google/pryo: Update touchscreen device ACPI nodes
    
    1. For ELAN, export reset GPIO as well as PowerResource
    2. For WCOM, export PowerResource
    
    BUG=chrome-os-partner:62311, chrome-os-partner:60194, chrome-os-partner:62371
    BRANCH=reef
    TEST=Verified that touchscreen works on pyro with WCOM device on
    power-on as well as after suspend/resume.
    
    Change-Id: I0306e24e19bf821cd3e08fdacc0d78b494c9a92f
    Signed-off-by: Furquan Shaikh <furquan at chromium.org>
---
 3rdparty/arm-trusted-firmware                         |  2 +-
 3rdparty/chromeec                                     |  2 +-
 src/mainboard/google/reef/variants/pyro/devicetree.cb | 17 +++++++++--------
 3 files changed, 11 insertions(+), 10 deletions(-)

diff --git a/3rdparty/arm-trusted-firmware b/3rdparty/arm-trusted-firmware
index 236c27d..bfd9251 160000
--- a/3rdparty/arm-trusted-firmware
+++ b/3rdparty/arm-trusted-firmware
@@ -1 +1 @@
-Subproject commit 236c27d21f52ad8f0a998e54774e3d8a4b59129d
+Subproject commit bfd925139fdbc2e87979849907b34843aa326994
diff --git a/3rdparty/chromeec b/3rdparty/chromeec
index bcffec7..ea1a869 160000
--- a/3rdparty/chromeec
+++ b/3rdparty/chromeec
@@ -1 +1 @@
-Subproject commit bcffec7fdc50e959cb298d094d8af472777dba75
+Subproject commit ea1a8699e96425806abdd532d04da254ae093f6e
diff --git a/src/mainboard/google/reef/variants/pyro/devicetree.cb b/src/mainboard/google/reef/variants/pyro/devicetree.cb
index 193fdd8..4713efe 100644
--- a/src/mainboard/google/reef/variants/pyro/devicetree.cb
+++ b/src/mainboard/google/reef/variants/pyro/devicetree.cb
@@ -172,6 +172,9 @@ chip soc/intel/apollolake
 					 .desc = WCOM_TS_DESC,
 					 .irq = IRQ_LEVEL_LOW(GPIO_21_IRQ),
 					 .probed = 1,
+					 .reset_gpio = ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_36),
+					 .enable_gpio = ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_152),
+					 .has_power_resource = 1,
 				}"
 				register "hid_desc_reg_offset" = "0x1"
 				device i2c 0xA on end
@@ -181,14 +184,12 @@ chip soc/intel/apollolake
 				register "desc" = ""ELAN Touchscreen""
 				register "irq" = "IRQ_EDGE_LOW(GPIO_21_IRQ)"
 				register "probed" = "1"
-
-				chip drivers/generic/gpio_regulator
-					register "name" = ""vcc33""
-					register "gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_152)"
-					register "enabled_on_boot" = "1"
-					device generic 0 on end
-				end
-
+				register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_36)"
+				register "reset_delay_ms" = "20"
+				register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_152)"
+				register "enable_delay_ms" = "1"
+				register "export_gpio_to_crs" = "1"
+				register "has_power_resource" = "1"
 				device i2c 10 on end
 			end
 		end	# - I2C 3



More information about the coreboot-gerrit mailing list