[coreboot-gerrit] New patch to review for coreboot: google/eve: Enable PD MCU device

Duncan Laurie (dlaurie@chromium.org) gerrit at coreboot.org
Mon Jan 23 22:10:41 CET 2017


Duncan Laurie (dlaurie at chromium.org) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/18209

-gerrit

commit f1c93f01595ebada08e6f0c22bbd71cfaf745ba8
Author: Duncan Laurie <dlaurie at chromium.org>
Date:   Fri Jan 20 14:16:55 2017 -0800

    google/eve: Enable PD MCU device
    
    In order for PD charge events to properly notify the OS when a charger is
    attached we need to enable the PD MCU device and event source from the EC.
    
    Without this change the charging still happens, but the OS does not notice
    and update the charge state icon in the Chrome OS UI.
    
    BUG=chrome-os-partner:62206
    BRANCH=none
    TEST=plug in a charger to either port and see charge status updated to
    indicate charging in the power_supply_info tool and the Chrome OS UI.
    
    Change-Id: Ia6f63ac719b739326d313f657a68005c32f45b8d
    Signed-off-by: Duncan Laurie <dlaurie at chromium.org>
---
 src/mainboard/google/eve/ec.h | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/src/mainboard/google/eve/ec.h b/src/mainboard/google/eve/ec.h
index 25fddfc..d0e59e1 100644
--- a/src/mainboard/google/eve/ec.h
+++ b/src/mainboard/google/eve/ec.h
@@ -34,7 +34,8 @@
 	 EC_HOST_EVENT_MASK(EC_HOST_EVENT_THERMAL_OVERLOAD)  |\
 	 EC_HOST_EVENT_MASK(EC_HOST_EVENT_THROTTLE_START)    |\
 	 EC_HOST_EVENT_MASK(EC_HOST_EVENT_THROTTLE_STOP)     |\
-	 EC_HOST_EVENT_MASK(EC_HOST_EVENT_MKBP))
+	 EC_HOST_EVENT_MASK(EC_HOST_EVENT_MKBP)              |\
+	 EC_HOST_EVENT_MASK(EC_HOST_EVENT_PD_MCU))
 
 #define MAINBOARD_EC_SMI_EVENTS \
 	(EC_HOST_EVENT_MASK(EC_HOST_EVENT_LID_CLOSED))
@@ -65,6 +66,9 @@
 /* Enable EC backed Keyboard Backlight in ACPI */
 #define EC_ENABLE_KEYBOARD_BACKLIGHT
 
+/* Enable EC backed PD MCU device in ACPI */
+#define EC_ENABLE_PD_MCU_DEVICE
+
 /* Enable LID switch and provide wake pin for EC */
 #define EC_ENABLE_LID_SWITCH
 #define EC_ENABLE_WAKE_PIN	GPE_EC_WAKE



More information about the coreboot-gerrit mailing list