[coreboot-gerrit] New patch to review for coreboot: vboot: vb2ex_printf() ignores null function name

Patrick Georgi (pgeorgi@google.com) gerrit at coreboot.org
Mon Jan 23 13:13:28 CET 2017


Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/18204

-gerrit

commit 208b50b87db401b31b606ea981eb14ebf0008cb8
Author: Randall Spangler <rspangler at chromium.org>
Date:   Fri Jan 20 14:48:53 2017 -0800

    vboot: vb2ex_printf() ignores null function name
    
    Currently, it will print the function name as a prefix to the debug
    output.  Make it so that a null function name won't get printed, so
    that it's possible to print little bits of debug output.
    
    BUG=chromium:683391
    BRANCH=none
    TEST=build_packages --board=reef chromeos-firmware
    
    Change-Id: I046fa766773fc08a29460db1f884d7902692d182
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Original-Commit-Id: 853ff7176e97e5e1ab664d094e1914c9c94510aa
    Original-Change-Id: I1dff38e4d8ab03118e5f8832a16d82c2d2116ec9
    Original-Signed-off-by: Randall Spangler <rspangler at chromium.org>
    Original-Reviewed-on: https://chromium-review.googlesource.com/431111
    Original-Reviewed-by: Julius Werner <jwerner at chromium.org>
---
 src/vboot/vboot_logic.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/vboot/vboot_logic.c b/src/vboot/vboot_logic.c
index bfed7d4..af7e947 100644
--- a/src/vboot/vboot_logic.c
+++ b/src/vboot/vboot_logic.c
@@ -42,7 +42,9 @@ void vb2ex_printf(const char *func, const char *fmt, ...)
 {
 	va_list args;
 
-	printk(BIOS_INFO, "VB2:%s() ", func);
+	if (func)
+		printk(BIOS_INFO, "VB2:%s() ", func);
+
 	va_start(args, fmt);
 	do_printk_va_list(BIOS_INFO, fmt, args);
 	va_end(args);



More information about the coreboot-gerrit mailing list