[coreboot-gerrit] New patch to review for coreboot: google/eve: Enable keyboard backlight in bootblock
Duncan Laurie (dlaurie@chromium.org)
gerrit at coreboot.org
Sun Jan 22 00:47:23 CET 2017
Duncan Laurie (dlaurie at chromium.org) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/18197
-gerrit
commit 0e07ce0ece7e6865fb5fa0e47e17fc84bcf3b83c
Author: Duncan Laurie <dlaurie at chromium.org>
Date: Sat Jan 21 15:42:26 2017 -0800
google/eve: Enable keyboard backlight in bootblock
Enable the keyboard backlight as early in boot as possible to
provide a indication that the BIOS is executing.
Since this is bootblock it can't use the convenience function
for checking for S3 resume so just read the PM1 value from the
SOC and check it directly.
Use a value of 75% for the current system as that is visible
without being full brightness.
BUG=chrome-os-partner:61464
TEST=boot on eve and check that keyboard backlight is enabled
as soon as the SOC starts booting
Change-Id: I9ac78e9c3913a2776943088f35142afe3ffef056
Signed-off-by: Duncan Laurie <dlaurie at chromium.org>
---
src/mainboard/google/eve/bootblock.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/src/mainboard/google/eve/bootblock.c b/src/mainboard/google/eve/bootblock.c
index 2c524f4..00d265c 100644
--- a/src/mainboard/google/eve/bootblock.c
+++ b/src/mainboard/google/eve/bootblock.c
@@ -14,9 +14,13 @@
* GNU General Public License for more details.
*/
+#include <arch/io.h>
#include <bootblock_common.h>
+#include <ec/google/chromeec/ec.h>
#include <gpio.h>
#include <soc/gpio.h>
+#include <soc/iomap.h>
+#include <soc/pm.h>
#include "gpio.h"
static void early_config_gpio(void)
@@ -26,5 +30,9 @@ static void early_config_gpio(void)
void bootblock_mainboard_init(void)
{
+ /* Turn on keyboard backlight to indicate we are booting */
+ if (acpi_sleep_from_pm1(inl(ACPI_BASE_ADDRESS + PM1_STS)) != ACPI_S3)
+ google_chromeec_kbbacklight(75);
+
early_config_gpio();
}
More information about the coreboot-gerrit
mailing list