[coreboot-gerrit] New patch to review for coreboot: soc/intel/skylake: Set FSP-S UPD PchHdaIDispCodecDisconnect to 1

Barnali Sarkar (barnali.sarkar@intel.com) gerrit at coreboot.org
Thu Jan 19 05:00:01 CET 2017


Barnali Sarkar (barnali.sarkar at intel.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/18091

-gerrit

commit 409483548305ffd5de1fc9ff7ae62b4345bde091
Author: Barnali Sarkar <barnali.sarkar at intel.com>
Date:   Tue Jan 10 22:09:00 2017 +0530

    soc/intel/skylake: Set FSP-S UPD PchHdaIDispCodecDisconnect to 1
    
    As per Audio PCH team recommendation the iDisplay Audio/SDIN2
    should be disabled to bypass InitializeDisplayAudio() function
    call. Display Audio Codec is HDA-Link Codec, which is not
    supported in I2S mode
    
    BUG=chrome-os-partner:61548
    BRANCH=none
    TEST=Tested to verify that InitializeDisplayAudio() does not
    gets called.
    
    Change-Id: Ie0771a8653821e737d10e876313917b4b7c64499
    Signed-off-by: Barnali Sarkar <barnali.sarkar at intel.com>
---
 src/soc/intel/skylake/chip.c       | 1 +
 src/soc/intel/skylake/chip_fsp20.c | 1 +
 2 files changed, 2 insertions(+)

diff --git a/src/soc/intel/skylake/chip.c b/src/soc/intel/skylake/chip.c
index c64a8df..45aa7d6 100644
--- a/src/soc/intel/skylake/chip.c
+++ b/src/soc/intel/skylake/chip.c
@@ -136,6 +136,7 @@ void soc_silicon_init_params(SILICON_INIT_UPD *params)
 	params->IshEnable = 0;
 	params->EnableAzalia = config->EnableAzalia;
 	params->IoBufferOwnership = config->IoBufferOwnership;
+	params->PchHdaIDispCodecDisconnect = 1;
 	params->DspEnable = config->DspEnable;
 	params->XdciEnable = config->XdciEnable;
 	params->Device4Enable = config->Device4Enable;
diff --git a/src/soc/intel/skylake/chip_fsp20.c b/src/soc/intel/skylake/chip_fsp20.c
index a1e76a9..55e9c53 100644
--- a/src/soc/intel/skylake/chip_fsp20.c
+++ b/src/soc/intel/skylake/chip_fsp20.c
@@ -180,6 +180,7 @@ void platform_fsp_silicon_init_params_cb(FSPS_UPD *supd)
 	params->PchIshEnable = config->IshEnable;
 	params->PchHdaEnable = config->EnableAzalia;
 	params->PchHdaIoBufferOwnership = config->IoBufferOwnership;
+	params->PchHdaIDispCodecDisconnect = 1;
 	params->PchHdaDspEnable = config->DspEnable;
 	params->XdciEnable = config->XdciEnable;
 	params->Device4Enable = config->Device4Enable;



More information about the coreboot-gerrit mailing list