[coreboot-gerrit] Patch merged into coreboot/master: cbfstool: Don't use le32toh(), it's non-standard

gerrit at coreboot.org gerrit at coreboot.org
Wed Jan 18 17:43:22 CET 2017


the following patch was just integrated into master:
commit 607796a4ff169f375e63853713cfeef0a89a0b2c
Author: Nico Huber <nico.huber at secunet.com>
Date:   Tue Jan 17 13:01:25 2017 +0100

    cbfstool: Don't use le32toh(), it's non-standard
    
    It's a BSD function, also, we missed to include `endian.h`.
    
    Just including `endian.h` doesn't fix the problem for everyone.
    Instead of digging deeper, just use our own endian-conversion from
    `commonlib`.
    
    Change-Id: Ia781b2258cafb0bcbe8408752a133cd28a888786
    Reported-by: Werner Zeh <werner.zeh at siemens.com>
    Signed-off-by: Nico Huber <nico.huber at secunet.com>
    Reviewed-on: https://review.coreboot.org/18157
    Reviewed-by: Paul Menzel <paulepanter at users.sourceforge.net>
    Tested-by: build bot (Jenkins)
    Reviewed-by: Patrick Georgi <pgeorgi at google.com>
    Reviewed-by: Werner Zeh <werner.zeh at siemens.com>


See https://review.coreboot.org/18157 for details.

-gerrit



More information about the coreboot-gerrit mailing list