[coreboot-gerrit] New patch to review for coreboot: util/intelmetool: Try to activate the ME before scanning PCIe for it

Dan Elkouby (streetwalkermc@gmail.com) gerrit at coreboot.org
Mon Jan 16 19:11:12 CET 2017


Dan Elkouby (streetwalkermc at gmail.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/18149

-gerrit

commit 58eb4f50da0707334a7faccb93429d6c8dc6a939
Author: Dan Elkouby <streetwalrus at codewalr.us>
Date:   Mon Jan 16 20:04:51 2017 +0200

    util/intelmetool: Try to activate the ME before scanning PCIe for it
    
    When the ME is hidden (most likely because it was disabled), it cannot
    be found until activate_me() is called.
    
    Change-Id: Ie1f65f61eb131577d7254af582e2709660f4da27
    Signed-off-by: Dan Elkouby <streetwalrus at codewalr.us>
---
 util/intelmetool/intelmetool.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/util/intelmetool/intelmetool.c b/util/intelmetool/intelmetool.c
index 7ffd535..70b23fb 100644
--- a/util/intelmetool/intelmetool.c
+++ b/util/intelmetool/intelmetool.c
@@ -68,7 +68,7 @@ static void rehide_me() {
 		printf("Re-hiding MEI device...");
 		fd2 = *(uint32_t *)(rcba + FD2);
 		*(uint32_t *)(rcba + FD2) = fd2 | 0x2;
-		printf("done, ");
+		printf("done\n");
 	}
 }
 
@@ -231,12 +231,12 @@ static void dump_me_info() {
 		exit(1);
 	}
 
-	dev = pci_me_interface_scan(&name);
-	if (!dev) {
+	if (activate_me()) {
 		exit(1);
 	}
 
-	if (activate_me()) {
+	dev = pci_me_interface_scan(&name);
+	if (!dev) {
 		exit(1);
 	}
 



More information about the coreboot-gerrit mailing list