[coreboot-gerrit] New patch to review for coreboot: util/scripts: extend cross-repo-cherrypick
Patrick Georgi (pgeorgi@google.com)
gerrit at coreboot.org
Fri Jan 13 19:13:57 CET 2017
Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/18135
-gerrit
commit be1375d19be0c8652dce4a00d39b03d899b86d39
Author: Patrick Georgi <pgeorgi at chromium.org>
Date: Fri Jan 13 19:11:29 2017 +0100
util/scripts: extend cross-repo-cherrypick
The script now automatically discovers the original branch (if known)
and configures itself appropriately.
Additionally, commit messages for changes coming _from_ upstream will
be prefixed with "UPSTREAM: ".
With the optional --cros argument, it also adds a BUG/BRANCH/TEST block
at the right place in the commit message (right above the metadata) if
one doesn't already exist.
Change-Id: I81864ddca62fd99a9eb905d7075e5b53f58c4eb5
Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
---
util/scripts/cross-repo-cherrypick | 34 +++++++++++++++++++++++++++++-----
1 file changed, 29 insertions(+), 5 deletions(-)
diff --git a/util/scripts/cross-repo-cherrypick b/util/scripts/cross-repo-cherrypick
index 9247cc2..0f2acf8 100755
--- a/util/scripts/cross-repo-cherrypick
+++ b/util/scripts/cross-repo-cherrypick
@@ -2,7 +2,7 @@
# rebase.sh - rebase helper script
#
-# Copyright 2015 Google Inc.
+# Copyright 2015, 2017 Google Inc.
#
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
@@ -15,7 +15,7 @@
#
# Adapt to your remote branch:
-BRANCH="cros/chromeos-2016.05"
+BRANCH="origin/master"
# When pulling in patches from another tree from a gerrit repository,
# do the following at the end of a larger cherry-pick series:
@@ -26,10 +26,32 @@ BRANCH="cros/chromeos-2016.05"
# Alternatively, you can run util/gitconfig/rebase.sh after every
# individual cherry-pick.
+# use $0 --cros to add a stub BUG/BRANCH/TEST block
+
commit_message() {
git log -n 1 | grep "^ " | cut -c5-
}
+ORIGIN_HOST=$( commit_message |grep "^Reviewed-on: " |head -1 |cut -d/ -f3 )
+case "${ORIGIN_HOST}" in
+ review.coreboot.org)
+ BRANCH="origin/master"
+ MESSAGE_PREFIX="UPSTREAM: "
+ ;;
+ chromium-review.googlesource.com)
+ BRANCH="cros/chromeos-2016.05"
+ MESSAGE_PREFIX=""
+ ;;
+esac
+
+# lines must be backwards due to tac(1)
+SPLICE_CMD=""
+if test "$1" = "--cros"; then
+ if test -z "$( commit_message |egrep '^(BUG|TEST)=')"; then
+ SPLICE_CMD='print "\nTEST=none\nBRANCH=none\nBUG=none\n"'
+ fi
+fi
+
CHID=$( commit_message | grep -i "^Change-Id: I" )
CID=$( git log -n1 --grep "^$CHID$" --pretty=%H $BRANCH )
GUID="$(git config user.name) <$(git config user.email)>"
@@ -37,9 +59,11 @@ GUID="$(git config user.name) <$(git config user.email)>"
# TBD: Don't add Original- to empty lines, and possibly make script more
# solid for commits with an unexpected order of meta data lines.
-commit_message | tac | awk '/^$/ {
- if (end==0)
- print "Original-Commit-Id: '"$CID"'\nSigned-off-by: '"$GUID"'";
+(printf "${MESSAGE_PREFIX}"; commit_message) | tac | awk '/^$/ {
+ if (end==0) {
+ print "Original-Commit-Id: '"${CID}"'\nSigned-off-by: '"${GUID}"'";
+ '"${SPLICE_CMD}"'
+ }
end=1
}; {
if (end==0)
More information about the coreboot-gerrit
mailing list