[coreboot-gerrit] Patch merged into coreboot/master: sb/intel/fsp_rangeley: Fix NULL check in gpio.c

gerrit at coreboot.org gerrit at coreboot.org
Thu Jan 12 18:37:57 CET 2017


the following patch was just integrated into master:
commit 6e4cb50420b7ddfecf9388e8a3b000ecb6855054
Author: Martin Roth <martinroth at google.com>
Date:   Tue Jan 10 16:40:45 2017 -0700

    sb/intel/fsp_rangeley: Fix NULL check in gpio.c
    
    This should always have been an and, not an or.
    
    The only way this would happen is if no GPIOs were getting configured,
    so we shouldn't ever have a NULL here, but if we did, GPIOs would
    be randomly configured, which would have 'interesting' results.
    
    Found-by: Coverity Scan #1229633 & 1229632
    Change-Id: If123372658383f84279738e1186425beba3208ca
    Signed-off-by: Martin Roth <martinroth at google.com>
    Reviewed-on: https://review.coreboot.org/18095
    Tested-by: build bot (Jenkins)
    Reviewed-by: Paul Menzel <paulepanter at users.sourceforge.net>
    Reviewed-by: Nico Huber <nico.h at gmx.de>


See https://review.coreboot.org/18095 for details.

-gerrit



More information about the coreboot-gerrit mailing list