[coreboot-gerrit] Patch set updated for coreboot: sb/intel/ibexpeak: Update debug code to match other chips
Martin Roth (martinroth@google.com)
gerrit at coreboot.org
Thu Jan 12 17:26:24 CET 2017
Martin Roth (martinroth at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/18101
-gerrit
commit ef10e386db0e58741829fb3dfb91586f795a49e2
Author: Martin Roth <martinroth at google.com>
Date: Wed Jan 11 10:10:17 2017 -0700
sb/intel/ibexpeak: Update debug code to match other chips
Other chips dump tco_status here if it wasn't handled, which makes
sense.
tco_sts can't be zero here, because the call would have already returned
if it were. Also, dump_tco_status wouldn't print anything if tco_sts
were zero.
This will still only print the debug information if DEBUG_SMI is
enabled in Kconfig, so in general, this change won't have much of an
effect on anything.
Found-by: Coverity Scan #1229598
Change-Id: Id2c69a16817ba18dfa051f514138fbc04a2f7bee
Signed-off-by: Martin Roth <martinroth at google.com>
---
src/southbridge/intel/ibexpeak/smihandler.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/southbridge/intel/ibexpeak/smihandler.c b/src/southbridge/intel/ibexpeak/smihandler.c
index ec91bdf..a0b963e 100644
--- a/src/southbridge/intel/ibexpeak/smihandler.c
+++ b/src/southbridge/intel/ibexpeak/smihandler.c
@@ -709,7 +709,7 @@ static void southbridge_smi_tco(void)
} else if (tco_sts & (1 << 3)) { /* TIMEOUT */
/* Handle TCO timeout */
printk(BIOS_DEBUG, "TCO Timeout.\n");
- } else if (!tco_sts) {
+ } else {
dump_tco_status(tco_sts);
}
}
More information about the coreboot-gerrit
mailing list