[coreboot-gerrit] New patch to review for coreboot: sb/nvidia/mcp55: Fix typo in nic.c
Martin Roth (martinroth@google.com)
gerrit at coreboot.org
Wed Jan 11 17:44:51 CET 2017
Martin Roth (martinroth at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/18100
-gerrit
commit c8210ec73f0381ea17e6bc25f5619dcf20983917
Author: Martin Roth <martinroth at google.com>
Date: Wed Jan 11 09:43:52 2017 -0700
sb/nvidia/mcp55: Fix typo in nic.c
The comparison value was obviously wrong here. One too many 'f'
characters.
Found-by: Coverity Scan #1229588 & 1229604
Change-Id: Iedd4f956d846f1c8661390b346c7397346def86b
Signed-off-by: Martin Roth <martinroth at google.com>
---
src/southbridge/nvidia/mcp55/nic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/southbridge/nvidia/mcp55/nic.c b/src/southbridge/nvidia/mcp55/nic.c
index 2474ef3..be9daf7 100644
--- a/src/southbridge/nvidia/mcp55/nic.c
+++ b/src/southbridge/nvidia/mcp55/nic.c
@@ -72,7 +72,7 @@ static void phy_detect(u8 *base)
val = phy_read(base, phyaddr, 1);
if (val < 0)
continue;
- if ((val & 0xffff) == 0xfffff)
+ if ((val & 0xffff) == 0xffff)
continue;
if ((val & 0xffff) == 0)
continue;
More information about the coreboot-gerrit
mailing list