[coreboot-gerrit] Patch set updated for coreboot: amd/mct/ddr3: Fix unintended sign extension warning
Timothy Pearson (tpearson@raptorengineering.com)
gerrit at coreboot.org
Wed Jan 11 00:24:01 CET 2017
Timothy Pearson (tpearson at raptorengineering.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/18077
-gerrit
commit cd28926900e56a6e830a68e9eaa8ccb632b8a6ae
Author: Timothy Pearson <tpearson at raptorengineering.com>
Date: Mon Jan 9 17:40:21 2017 -0600
amd/mct/ddr3: Fix unintended sign extension warning
An unintended sign extension warning was thrown by Coverity.
Explicitly state the length of the constant multiplier.
Found-by: Coverity Scan #1347342
Change-Id: Icd42eec13be04fc5fd2ffc85320cbadafc852148
Signed-off-by: Timothy Pearson <tpearson at raptorengineering.com>
---
src/northbridge/amd/amdmct/mct_ddr3/mct_d.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/northbridge/amd/amdmct/mct_ddr3/mct_d.c b/src/northbridge/amd/amdmct/mct_ddr3/mct_d.c
index f726345..b64ad54 100644
--- a/src/northbridge/amd/amdmct/mct_ddr3/mct_d.c
+++ b/src/northbridge/amd/amdmct/mct_ddr3/mct_d.c
@@ -2474,10 +2474,10 @@ static void set_up_cc6_storage_fam15(struct MCTStatStruc *pMCTstat,
if (interleaved)
/* Move upper limit down by 16M * the number of nodes */
- max_range_limit -= (0x1000000 * num_nodes);
+ max_range_limit -= (0x1000000ULL * num_nodes);
else
/* Move upper limit down by 16M */
- max_range_limit -= 0x1000000;
+ max_range_limit -= 0x1000000ULL;
printk(BIOS_INFO, "%s:\tnew max_range_limit: %16llx\n",
__func__, max_range_limit);
More information about the coreboot-gerrit
mailing list