[coreboot-gerrit] New patch to review for coreboot: devtree: Drop unused parameter show_devs_tree() call

Kyösti Mälkki (kyosti.malkki@gmail.com) gerrit at coreboot.org
Tue Jan 10 14:36:09 CET 2017


Kyösti Mälkki (kyosti.malkki at gmail.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/18085

-gerrit

commit 481192e72a42431e0ea126630779f3d52c0cdc52
Author: Kyösti Mälkki <kyosti.malkki at gmail.com>
Date:   Mon Aug 15 10:04:21 2016 +0300

    devtree: Drop unused parameter show_devs_tree() call
    
    Change-Id: I14c044bb32713ef4133bce8a8238a2bc200c4959
    Signed-off-by: Kyösti Mälkki <kyosti.malkki at gmail.com>
---
 src/device/device.c         | 2 +-
 src/device/device_util.c    | 8 ++++----
 src/include/device/device.h | 2 +-
 3 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/device/device.c b/src/device/device.c
index 9ea32cc..0231ec7 100644
--- a/src/device/device.c
+++ b/src/device/device.c
@@ -989,7 +989,7 @@ void dev_enumerate(void)
 
 	show_all_devs(BIOS_SPEW, "Before device enumeration.");
 	printk(BIOS_SPEW, "Compare with tree...\n");
-	show_devs_tree(root, BIOS_SPEW, 0, 0);
+	show_devs_tree(root, BIOS_SPEW, 0);
 
 	if (root->chip_ops && root->chip_ops->enable_dev)
 		root->chip_ops->enable_dev(root);
diff --git a/src/device/device_util.c b/src/device/device_util.c
index cd33aac..1a0a60f 100644
--- a/src/device/device_util.c
+++ b/src/device/device_util.c
@@ -813,7 +813,7 @@ void print_resource_tree(struct device *root, int debug_level, const char *msg)
 	resource_tree(root, debug_level, 0);
 }
 
-void show_devs_tree(struct device *dev, int debug_level, int depth, int linknum)
+void show_devs_tree(struct device *dev, int debug_level, int depth)
 {
 	char depth_str[20];
 	int i;
@@ -830,7 +830,7 @@ void show_devs_tree(struct device *dev, int debug_level, int depth, int linknum)
 	for (link = dev->link_list; link; link = link->next) {
 		for (sibling = link->children; sibling;
 		     sibling = sibling->sibling)
-			show_devs_tree(sibling, debug_level, depth + 1, i);
+			show_devs_tree(sibling, debug_level, depth + 1);
 	}
 }
 
@@ -839,7 +839,7 @@ void show_all_devs_tree(int debug_level, const char *msg)
 	/* Bail if not printing to screen. */
 	if (!do_printk(debug_level, "Show all devs in tree form... %s\n", msg))
 		return;
-	show_devs_tree(all_devices, debug_level, 0, -1);
+	show_devs_tree(all_devices, debug_level, 0);
 }
 
 void show_devs_subtree(struct device *root, int debug_level, const char *msg)
@@ -849,7 +849,7 @@ void show_devs_subtree(struct device *root, int debug_level, const char *msg)
 		       dev_path(root), msg))
 		return;
 	do_printk(debug_level, "%s\n", msg);
-	show_devs_tree(root, debug_level, 0, -1);
+	show_devs_tree(root, debug_level, 0);
 }
 
 void show_all_devs(int debug_level, const char *msg)
diff --git a/src/include/device/device.h b/src/include/device/device.h
index 39bf718..47509f7 100644
--- a/src/include/device/device.h
+++ b/src/include/device/device.h
@@ -214,7 +214,7 @@ void set_cpu_topology(device_t cpu, unsigned node, unsigned package, unsigned co
 /* Debug functions */
 void print_resource_tree(struct device * root, int debug_level,
 			 const char *msg);
-void show_devs_tree(struct device *dev, int debug_level, int depth, int linknum);
+void show_devs_tree(struct device *dev, int debug_level, int depth);
 void show_devs_subtree(struct device *root, int debug_level, const char *msg);
 void show_all_devs(int debug_level, const char *msg);
 void show_all_devs_tree(int debug_level, const char *msg);



More information about the coreboot-gerrit mailing list