[coreboot-gerrit] New patch to review for coreboot: amd/mct/ddr3: Correctly configure CsMux45

Timothy Pearson (tpearson@raptorengineering.com) gerrit at coreboot.org
Mon Jan 9 20:22:46 CET 2017


Timothy Pearson (tpearson at raptorengineering.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/18070

-gerrit

commit f6aabd7f3055aec576c2c76da62829ae3321d6d7
Author: Timothy Pearson <tpearson at raptorengineering.com>
Date:   Mon Jan 9 13:19:29 2017 -0600

    amd/mct/ddr3: Correctly configure CsMux45
    
    The existing logic to set up CsMux45 used an incorrect mask
    and comparison value due to a copy + paste editing error.
    
    Use the correct mask and comparison value for the last two
    values.
    
    Change-Id: Ic08a52977df90b9952e434e71cd12dbc6d7e1443
    Found-by: Coverity Scan #1347385
    Signed-off-by: Timothy Pearson <tpearson at raptorengineering.com>
---
 src/northbridge/amd/amdmct/mct_ddr3/mctproc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/northbridge/amd/amdmct/mct_ddr3/mctproc.c b/src/northbridge/amd/amdmct/mct_ddr3/mctproc.c
index 07bde27..48658f5 100644
--- a/src/northbridge/amd/amdmct/mct_ddr3/mctproc.c
+++ b/src/northbridge/amd/amdmct/mct_ddr3/mctproc.c
@@ -43,7 +43,7 @@ u32 mct_SetDramConfigMisc2(struct DCTStatStruc *pDCTstat,
 			if ((((f2x80 & 0xf) == 0x7) || ((f2x80 & 0xf) == 0x9))
 				&& ((f2x60 & 0x3) == 0x3))
 				cs_mux_45 = 1;
-			else if ((((f2x80 & 0xa) == 0x7) || ((f2x80 & 0xb) == 0x9))
+			else if ((((f2x80 & 0xf) == 0xa) || ((f2x80 & 0xf) == 0xb))
 				&& ((f2x60 & 0x3) > 0x1))
 				cs_mux_45 = 1;
 			else



More information about the coreboot-gerrit mailing list