[coreboot-gerrit] Patch merged into coreboot/master: sb/ich7: Use common/gpio.h to set up GPIOs
gerrit at coreboot.org
gerrit at coreboot.org
Fri Jan 6 18:14:08 CET 2017
the following patch was just integrated into master:
commit 62902ca45de871aa59657dd8ec1858c301595634
Author: Arthur Heymans <arthur at aheymans.xyz>
Date: Tue Nov 29 14:13:43 2016 +0100
sb/ich7: Use common/gpio.h to set up GPIOs
This is more consistent with newer Intel targets.
This a static struct so it is initialized to 0 by default.
To make it more readable:
* only setting to GPIO mode is made explicit;
* only pins in GPIO mode are either set to input or output since this
is ignored in native mode;
* only output pins are set high or low, since this is read-only on
input;
* blink is only operational on output pins, non-blink is not set
explicitly;
* invert is only operational on input pins, non-invert is not set
explicitly.
Change-Id: I05f9c52dee78b7120b225982c040e3dcc8ee3e4e
Signed-off-by: Arthur Heymans <arthur at aheymans.xyz>
Reviewed-on: https://review.coreboot.org/17639
Tested-by: build bot (Jenkins)
Reviewed-by: Nico Huber <nico.h at gmx.de>
Reviewed-by: Patrick Rudolph <siro at das-labor.org>
Reviewed-by: Paul Menzel <paulepanter at users.sourceforge.net>
See https://review.coreboot.org/17639 for details.
-gerrit
More information about the coreboot-gerrit
mailing list