[coreboot-gerrit] Patch merged into coreboot/master: amdfam10: Perform major include ".c" cleanup

gerrit at coreboot.org gerrit at coreboot.org
Wed Jan 4 18:56:07 CET 2017


the following patch was just integrated into master:
commit 75a3d1fb7c31bc5bd287bf6579ff70c5da9275a7
Author: Damien Zammit <damien at zamaudio.com>
Date:   Mon Nov 28 00:29:10 2016 +1100

    amdfam10: Perform major include ".c" cleanup
    
    Previously, all romstages for this northbridge family
    would compile via 1 single C file with everything
    included into the romstage.c file (!)
    
    This patch separates the build into separate .o modules
    and links them accordingly.
    
    Currently compiles and links all fam10 roms without
    breaking other roms.
    
    Both DDR2 and DDR3 have been completed
    
    TESTED on REACTS: passes all boot tests for 2 boards
     ASUS KGPE-D16
     ASUS KFSN4-DRE
    
    Some extra changes were required to make it compile
    otherwise there were unused functions in included "c" files.
    This is because I needed to exchange CIMX
    for the native southbridge routines. See in particular:
     advansus/a785e-i
     asus/m5a88-v
     avalue/eax-785e
    
    A followup patch may be required to fix the above boards.
    See FIXME, XXX tags
    
    Change-Id: Id0f9849578fd0f8b1eab83aed910902c27354426
    Signed-off-by: Damien Zammit <damien at zamaudio.com>
    Reviewed-on: https://review.coreboot.org/17625
    Tested-by: build bot (Jenkins)
    Tested-by: Raptor Engineering Automated Test Stand <noreply at raptorengineeringinc.com>
    Reviewed-by: Timothy Pearson <tpearson at raptorengineering.com>


See https://review.coreboot.org/17625 for details.

-gerrit



More information about the coreboot-gerrit mailing list