[coreboot-gerrit] Patch merged into coreboot/master: rockchip/common: Loosen I2C frequency target requirements

gerrit at coreboot.org gerrit at coreboot.org
Tue Jan 3 22:13:55 CET 2017


the following patch was just integrated into master:
commit 7e1f68c4376b7d6714829cda2e69da4bcd8de2fa
Author: Julius Werner <jwerner at chromium.org>
Date:   Fri Dec 16 16:03:57 2016 -0800

    rockchip/common: Loosen I2C frequency target requirements
    
    I've recently added an assertion to ensure that the effective I2C
    frequency on Rockchip SoCs is not too far off the 400KHz target due to
    divisor rounding errors. A 10KHz margin worked fine for RK3399, but it
    turns out that RK3288 actually only ever hit 387KHz since its I2C clocks
    are based off the already pretty low 75MHz PCLKs. While we could
    probably change the PCLKs to make this closer, that seems like a too
    intrusive change for something that has already worked just fine for
    years, so just loosen the restriction a little more instead.
    
    BRANCH=None
    BUG=chromium:675043
    TEST=None
    
    Change-Id: I7e96a1a75b38f8ad3971dd33046699cceb17b80d
    Signed-off-by: Julius Werner <jwerner at chromium.org>
    Reviewed-on: https://chromium-review.googlesource.com/421095
    Reviewed-by: Randall Spangler <rspangler at chromium.org>
    Reviewed-on: https://review.coreboot.org/18007
    Reviewed-by: Paul Menzel <paulepanter at users.sourceforge.net>
    Tested-by: build bot (Jenkins)
    Reviewed-by: Martin Roth <martinroth at google.com>


See https://review.coreboot.org/18007 for details.

-gerrit



More information about the coreboot-gerrit mailing list