[coreboot-gerrit] New patch to review for coreboot: broadcom/bcm5785: don't treat KBC-DATA as COM1

Patrick Georgi (pgeorgi@google.com) gerrit at coreboot.org
Mon Jan 2 19:26:06 CET 2017


Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/18013

-gerrit

commit 540e396964209055d38ec1305281c63fec13393c
Author: Patrick Georgi <pgeorgi at chromium.org>
Date:   Mon Jan 2 13:14:18 2017 +0100

    broadcom/bcm5785: don't treat KBC-DATA as COM1
    
    Add a break statement instead.
    While there, fix a bunch of typos in comments.
    
    Change-Id: I465c0188d4b46eabf8d17e69fa0fdc6a9c2ad66e
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Found-by: Coverity Scan #1229645
---
 src/southbridge/broadcom/bcm5785/lpc.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/southbridge/broadcom/bcm5785/lpc.c b/src/southbridge/broadcom/bcm5785/lpc.c
index 59ba798..cc285a3 100644
--- a/src/southbridge/broadcom/bcm5785/lpc.c
+++ b/src/southbridge/broadcom/bcm5785/lpc.c
@@ -87,18 +87,18 @@ static void bcm5785_lpc_enable_childrens_resources(device_t dev)
 					switch(base) {
 					case 0x60: //KBC
 					case 0x64:
-						reg |= (1<<29);
+						reg |= (1<<29); break;
 					case 0x3f8: // COM1
 						reg |= (1<<6); 	break;
 					case 0x2f8: // COM2
 						reg |= (1<<7);  break;
-					case 0x378: // Parallal 1
+					case 0x378: // Parallel 1
 						reg |= (1<<0); break;
 					case 0x3f0: // FD0
 						reg |= (1<<26); break;
-					case 0x220:  // Aduio 0
+					case 0x220:  // Audio 0
 						reg |= (1<<14);	break;
-					case 0x300:  // Midi 0
+					case 0x300:  // MIDI 0
 						reg |= (1<<18);	break;
 					}
 				}



More information about the coreboot-gerrit mailing list